Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: NuGet icon is broken when building in ADO #5276

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Conversation

lokitoth
Copy link
Member

We use git-lfs for storing the icon, and cannot publish with a broken icon

We use git-lfs for storing the icon
@lokitoth lokitoth enabled auto-merge (squash) January 31, 2025 00:07
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.59%. Comparing base (b05878a) to head (12deb41).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5276   +/-   ##
=======================================
  Coverage   70.59%   70.59%           
=======================================
  Files         180      180           
  Lines       11668    11668           
=======================================
  Hits         8237     8237           
  Misses       3431     3431           
Flag Coverage Δ
unittests 70.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lokitoth lokitoth merged commit a1b08aa into main Jan 31, 2025
67 checks passed
@lokitoth lokitoth deleted the dev/fix_nuget_icon branch January 31, 2025 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants