Allow getLiteralTypeFromProperty to extract name types from unions #60994

bgenia · 2025-01-18T04:33:37Z

Test is implemented using quick info comparison because I didn't find any other way to verify mapped type members. There is probably a better way of doing this.

jakebailey · 2025-01-18T05:59:26Z

@typescript-bot test it

typescript-bot · 2025-01-18T05:59:30Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2025-01-18T06:20:12Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2025-01-18T06:38:26Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/60994/merge:

Everything looks good!

typescript-bot · 2025-01-18T06:41:37Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₄	₃₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,390	_62,390	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,395	_50,395	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{196,290k (± 0.78%)}	_{195,564k (± 1.05%)}	_~	_192,854k	_196,941k	_{p=0.261 n=6}
_{Parse Time}	_{1.61s (± 0.72%)}	_{1.62s (± 1.03%)}	_~	_1.60s	_1.64s	_{p=0.410 n=6}
_{Bind Time}	_{0.88s (± 1.18%)}	_{0.88s (± 0.59%)}	_~	_0.87s	_0.88s	_{p=0.142 n=6}
_{Check Time}	_{11.76s (± 0.44%)}	_{11.80s (± 0.41%)}	_~	_11.76s	_11.86s	_{p=0.141 n=6}
_{Emit Time}	_{3.32s (± 1.32%)}	_{3.38s (± 3.52%)}	_~	_3.25s	_3.57s	_{p=0.936 n=6}
_{Total Time}	_{17.57s (± 0.27%)}	_{17.68s (± 0.72%)}	_~	_17.57s	_17.85s	_{p=0.126 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₃₇	₃₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_947,969	_947,969	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,955	_410,955	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,225,672k (± 0.00%)}	_{1,225,695k (± 0.01%)}	_~	_1,225,607k	_1,225,837k	_{p=0.575 n=6}
_{Parse Time}	_{6.65s (± 1.03%)}	_{6.64s (± 1.00%)}	_~	_6.56s	_6.71s	_{p=1.000 n=6}
_{Bind Time}	_{1.90s (± 0.62%)}	_{1.89s (± 0.52%)}	_~	_1.88s	_1.90s	_{p=0.314 n=6}
_{Check Time}	_{31.99s (± 0.39%)}	_{32.02s (± 0.29%)}	_~	_31.91s	_32.18s	_{p=1.000 n=6}
_{Emit Time}	_{15.20s (± 0.37%)}	_{15.18s (± 0.30%)}	_~	_15.13s	_15.25s	_{p=0.687 n=6}
_{Total Time}	_{55.74s (± 0.26%)}	_{55.74s (± 0.23%)}	_~	_55.61s	_55.98s	_{p=0.810 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,444,602	_2,444,602	_~	_~	_~	_{p=1.000 n=6}
_Types	_896,634	_896,634	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,305,841k (± 0.00%)}	_{2,305,852k (± 0.00%)}	_~	_2,305,739k	_2,305,926k	_{p=0.810 n=6}
_{Parse Time}	_{10.73s (± 0.30%)}	_{10.70s (± 0.50%)}	_~	_10.59s	_10.73s	_{p=0.331 n=6}
_{Bind Time}	_{2.51s (± 0.76%)}	_{2.51s (± 0.42%)}	_~	_2.50s	_2.53s	_{p=0.744 n=6}
_{Check Time}	_{87.27s (± 1.01%)}	_{87.07s (± 0.27%)}	_~	_86.84s	_87.49s	_{p=0.936 n=6}
_{Emit Time}	_{0.34s (± 3.22%)}	_{0.34s (± 3.01%)}	_~	_0.33s	_0.36s	_{p=0.546 n=6}
_{Total Time}	_{100.85s (± 0.85%)}	_{100.62s (± 0.23%)}	_~	_100.40s	_101.07s	_{p=0.936 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,228,459	_1,228,460	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,873	_266,873	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,360,296k (± 0.01%)}	_{2,359,850k (± 0.02%)}	_~	_2,359,149k	_2,360,545k	_{p=0.066 n=6}
_{Parse Time}	_{5.15s (± 1.02%)}	_{5.21s (± 1.23%)}	_~	_5.13s	_5.29s	_{p=0.149 n=6}
_{Bind Time}	_{1.78s (± 0.85%)}	_{1.79s (± 1.36%)}	_~	_1.75s	_1.81s	_{p=0.464 n=6}
_{Check Time}	_{35.25s (± 0.30%)}	_{35.27s (± 0.24%)}	_~	_35.19s	_35.38s	_{p=0.936 n=6}
_{Emit Time}	_{2.98s (± 1.15%)}	_{3.04s (± 3.41%)}	_~	_2.98s	_3.25s	_{p=0.332 n=6}
_{Total Time}	_{45.17s (± 0.28%)}	_{45.31s (± 0.23%)}	_~	_45.20s	_45.48s	_{p=0.066 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,228,459	_1,228,460	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,873	_266,873	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,427,695k (± 0.02%)}	_{2,427,358k (± 0.02%)}	_~	_2,426,862k	_2,428,124k	_{p=0.199 n=6}
_{Parse Time}	_{5.46s (± 0.99%)}	_{5.46s (± 0.76%)}	_~	_5.40s	_5.53s	_{p=0.873 n=6}
_{Bind Time}	_{1.78s (± 1.61%)}	_{1.81s (± 0.97%)}	_~	_1.78s	_1.83s	_{p=0.119 n=6}
_{Check Time}	_{35.32s (± 0.15%)}	_{35.27s (± 0.21%)}	_~	_35.20s	_35.36s	_{p=0.370 n=6}
_{Emit Time}	_{3.06s (± 0.45%)}	_{3.03s (± 1.21%)}	_~	_2.99s	_3.09s	_{p=0.092 n=6}
_{Total Time}	_{45.62s (± 0.20%)}	_{45.57s (± 0.21%)}	_~	_45.46s	_45.73s	_{p=0.336 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_262,628	_262,629	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_106,697	_106,697	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{440,570k (± 0.01%)}	_{440,571k (± 0.00%)}	_~	_440,546k	_440,591k	_{p=0.810 n=6}
_{Parse Time}	_{2.89s (± 0.92%)}	_{2.88s (± 0.61%)}	_~	_2.86s	_2.91s	_{p=0.624 n=6}
_{Bind Time}	_{1.11s (± 0.89%)}	_1.11s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{15.86s (± 0.34%)}	_{15.78s (± 0.08%)}	_{-0.08s (- 0.50%)}	_15.76s	_15.79s	_{p=0.016 n=6}
_{Emit Time}	_{1.29s (± 1.34%)}	_{1.28s (± 1.25%)}	_~	_1.27s	_1.31s	_{p=0.463 n=6}
_{Total Time}	_{21.14s (± 0.19%)}	_{21.06s (± 0.14%)}	_{-0.09s (- 0.42%)}	_21.02s	_21.10s	_{p=0.010 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₀	₇₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_226,095	_226,095	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,488	_94,488	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,880k (± 0.06%)}	_{371,652k (± 0.01%)}	_{-228k (- 0.06%)}	_371,617k	_371,689k	_{p=0.013 n=6}
_{Parse Time}	_{2.90s (± 1.20%)}	_{2.90s (± 1.08%)}	_~	_2.86s	_2.94s	_{p=0.568 n=6}
_{Bind Time}	_{1.60s (± 1.42%)}	_{1.58s (± 1.48%)}	_~	_1.55s	_1.62s	_{p=0.414 n=6}
_{Check Time}	_{16.49s (± 0.40%)}	_{16.48s (± 0.40%)}	_~	_16.40s	_16.58s	_{p=0.810 n=6}
_{Emit Time}	_{0.00s (±154.76%)}	_0.00s	_~	_~	_~	_{p=0.174 n=6}
_{Total Time}	_{21.00s (± 0.27%)}	_{20.96s (± 0.31%)}	_~	_20.86s	_21.03s	_{p=0.375 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,251,957	_3,251,957	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,119,191	_1,119,191	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,317,079k (± 0.01%)}	_{3,317,203k (± 0.01%)}	_~	_3,316,790k	_3,317,576k	_{p=0.471 n=6}
_{Parse Time}	_{14.24s (± 0.75%)}	_{14.22s (± 0.49%)}	_~	_14.13s	_14.28s	_{p=0.872 n=6}
_{Bind Time}	_{4.59s (± 0.40%)}	_{4.58s (± 0.51%)}	_~	_4.53s	_4.59s	_{p=0.491 n=6}
_{Check Time}	_{89.12s (± 2.33%)}	_{88.72s (± 1.54%)}	_~	_87.51s	_90.59s	_{p=0.810 n=6}
_{Emit Time}	_{27.94s (± 8.45%)}	_{28.37s (± 2.75%)}	_~	_27.59s	_29.16s	_{p=0.575 n=6}
_{Total Time}	_{135.89s (± 1.31%)}	_{135.88s (± 0.84%)}	_~	_133.83s	_137.07s	_{p=0.810 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_291,595	_291,595	_~	_~	_~	_{p=1.000 n=6}
_Types	_118,971	_118,971	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{445,380k (± 0.03%)}	_{445,411k (± 0.03%)}	_~	_445,199k	_445,525k	_{p=0.689 n=6}
_{Parse Time}	_{5.12s (± 1.16%)}	_{5.10s (± 1.20%)}	_~	_5.04s	_5.19s	_{p=0.688 n=6}
_{Bind Time}	_{2.22s (± 0.64%)}	_{2.20s (± 0.89%)}	_~	_2.18s	_2.23s	_{p=0.168 n=6}
_{Check Time}	_{23.43s (± 1.43%)}	_{23.32s (± 0.33%)}	_~	_23.18s	_23.42s	_{p=0.809 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{30.77s (± 1.10%)}	_{30.63s (± 0.35%)}	_~	_30.46s	_30.74s	_{p=0.689 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_555,050	_555,050	_~	_~	_~	_{p=1.000 n=6}
_Types	_186,115	_186,115	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{494,015k (± 0.02%)}	_{494,017k (± 0.01%)}	_~	_493,956k	_494,120k	_{p=0.748 n=6}
_{Parse Time}	_{3.41s (± 0.32%)}	_{3.41s (± 0.88%)}	_~	_3.37s	_3.44s	_{p=0.935 n=6}
_{Bind Time}	_{1.18s (± 0.69%)}	_{1.19s (± 0.63%)}	_~	_1.18s	_1.20s	_{p=0.120 n=6}
_{Check Time}	_{19.61s (± 0.32%)}	_{19.57s (± 0.15%)}	_~	_19.53s	_19.62s	_{p=0.193 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.20s (± 0.26%)}	_{24.17s (± 0.20%)}	_~	_24.12s	_24.25s	_{p=0.328 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2025-01-18T07:31:56Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/60994/merge:

Everything looks good!

bgenia added 2 commits January 18, 2025 06:28

Allow getLiteralTypeFromProperty to extract name types from unions

b0a1df3

Add tests

12b9bd4

typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Jan 18, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow getLiteralTypeFromProperty to extract name types from unions #60994

Allow getLiteralTypeFromProperty to extract name types from unions #60994

bgenia commented Jan 18, 2025

jakebailey commented Jan 18, 2025

typescript-bot commented Jan 18, 2025 •

edited

Loading

typescript-bot commented Jan 18, 2025

typescript-bot commented Jan 18, 2025

typescript-bot commented Jan 18, 2025

tsc

typescript-bot commented Jan 18, 2025

Allow getLiteralTypeFromProperty to extract name types from unions #60994

Are you sure you want to change the base?

Allow getLiteralTypeFromProperty to extract name types from unions #60994

Conversation

bgenia commented Jan 18, 2025

jakebailey commented Jan 18, 2025

typescript-bot commented Jan 18, 2025 • edited Loading

typescript-bot commented Jan 18, 2025

typescript-bot commented Jan 18, 2025

typescript-bot commented Jan 18, 2025

tsc

typescript-bot commented Jan 18, 2025

typescript-bot commented Jan 18, 2025 •

edited

Loading