Fixed an issue with for statement's incrementor missing continue's control flow information #60950

Andarist · 2025-01-11T10:50:06Z

…ntrol flow information

jakebailey · 2025-01-11T14:31:55Z

typescript-bot · 2025-01-11T14:31:59Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2025-01-11T14:52:14Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2025-01-11T14:52:44Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/60950/merge:

Everything looks good!

typescript-bot · 2025-01-11T15:14:11Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₄	₃₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,390	_62,390	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,395	_50,395	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,117k (± 0.01%)}	_{194,337k (± 0.97%)}	_~	_193,102k	_196,769k	_{p=0.295 n=6}
_{Parse Time}	_{1.31s (± 0.92%)}	_{1.31s (± 0.31%)}	_~	_1.30s	_1.31s	_{p=0.116 n=6}
_{Bind Time}	_0.73s	_0.73s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.76s (± 0.27%)}	_{9.78s (± 0.35%)}	_~	_9.74s	_9.83s	_{p=0.468 n=6}
_{Emit Time}	_{2.74s (± 0.44%)}	_{2.72s (± 0.46%)}	_~	_2.70s	_2.73s	_{p=0.067 n=6}
_{Total Time}	_{14.54s (± 0.32%)}	_{14.54s (± 0.26%)}	_~	_14.50s	_14.60s	_{p=0.807 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₃₇	₃₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_947,969	_947,970	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_410,955	_410,956	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{1,225,681k (± 0.01%)}	_{1,225,668k (± 0.00%)}	_~	_1,225,612k	_1,225,766k	_{p=0.575 n=6}
_{Parse Time}	_{6.67s (± 0.78%)}	_{6.62s (± 0.85%)}	_~	_6.55s	_6.71s	_{p=0.091 n=6}
_{Bind Time}	_1.90s	_{1.88s (± 0.48%)}	_{-0.02s (- 1.05%)}	_1.87s	_1.89s	_{p=0.003 n=6}
_{Check Time}	_{31.95s (± 0.37%)}	_{31.96s (± 0.28%)}	_~	_31.89s	_32.14s	_{p=0.423 n=6}
_{Emit Time}	_{15.19s (± 0.30%)}	_{15.16s (± 0.73%)}	_~	_14.93s	_15.21s	_{p=0.936 n=6}
_{Total Time}	_{55.71s (± 0.26%)}	_{55.61s (± 0.13%)}	_~	_55.51s	_55.74s	_{p=0.261 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,446,693	_2,446,693	_~	_~	_~	_{p=1.000 n=6}
_Types	_897,118	_897,118	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,310,898k (± 0.00%)}	_{2,310,932k (± 0.00%)}	_~	_2,310,832k	_2,311,032k	_{p=0.471 n=6}
_{Parse Time}	_{10.78s (± 0.51%)}	_{10.78s (± 0.30%)}	_~	_10.75s	_10.84s	_{p=0.809 n=6}
_{Bind Time}	_{2.51s (± 0.82%)}	_{2.54s (± 0.80%)}	_{+0.02s (+ 0.99%)}	_2.52s	_2.56s	_{p=0.040 n=6}
_{Check Time}	_{88.39s (± 1.53%)}	_{88.19s (± 1.27%)}	_~	_87.17s	_90.29s	_{p=0.936 n=6}
_{Emit Time}	_{0.35s (± 4.76%)}	_{0.35s (± 2.14%)}	_~	_0.34s	_0.36s	_{p=0.357 n=6}
_{Total Time}	_{102.04s (± 1.34%)}	_{101.86s (± 1.10%)}	_~	_100.85s	_103.95s	_{p=0.810 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,228,377	_1,228,378	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,839	_266,839	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,360,055k (± 0.02%)}	_{2,359,834k (± 0.02%)}	_~	_2,359,176k	_2,360,475k	_{p=0.378 n=6}
_{Parse Time}	_{5.15s (± 0.72%)}	_{5.22s (± 1.05%)}	_~	_5.12s	_5.28s	_{p=0.065 n=6}
_{Bind Time}	_{1.78s (± 0.66%)}	_{1.77s (± 0.83%)}	_~	_1.75s	_1.79s	_{p=0.137 n=6}
_{Check Time}	_{35.23s (± 0.51%)}	_{35.25s (± 0.42%)}	_~	_35.09s	_35.44s	_{p=1.000 n=6}
_{Emit Time}	_{2.98s (± 0.76%)}	_{3.01s (± 1.07%)}	_~	_2.98s	_3.07s	_{p=0.063 n=6}
_{Total Time}	_{45.16s (± 0.42%)}	_{45.24s (± 0.30%)}	_~	_45.09s	_45.39s	_{p=0.575 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,228,377	_1,228,378	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,839	_266,839	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,914,862k (±12.83%)}	_{2,672,938k (±14.02%)}	_~	_2,430,387k	_3,157,261k	_{p=0.298 n=6}
_{Parse Time}	_{6.91s (± 1.32%)}	_{6.85s (± 1.62%)}	_~	_6.73s	_6.99s	_{p=0.378 n=6}
_{Bind Time}	_{2.13s (± 1.80%)}	_{2.15s (± 1.65%)}	_~	_2.11s	_2.20s	_{p=0.196 n=6}
_{Check Time}	_{42.68s (± 0.41%)}	_{42.62s (± 0.45%)}	_~	_42.39s	_42.91s	_{p=0.689 n=6}
_{Emit Time}	_{3.50s (± 3.23%)}	_{3.46s (± 3.56%)}	_~	_3.38s	_3.71s	_{p=0.689 n=6}
_{Total Time}	_{55.21s (± 0.61%)}	_{55.08s (± 0.49%)}	_~	_54.72s	_55.42s	_{p=0.471 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_262,624	_262,625	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_106,695	_106,695	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{440,574k (± 0.01%)}	_{440,587k (± 0.02%)}	_~	_440,482k	_440,659k	_{p=0.575 n=6}
_{Parse Time}	_{2.87s (± 0.52%)}	_{2.88s (± 0.78%)}	_~	_2.86s	_2.91s	_{p=0.622 n=6}
_{Bind Time}	_{1.11s (± 0.37%)}	_1.11s	_~	_~	_~	_{p=0.405 n=6}
_{Check Time}	_{15.79s (± 0.46%)}	_{15.75s (± 0.32%)}	_~	_15.69s	_15.83s	_{p=0.198 n=6}
_{Emit Time}	_{1.31s (± 1.12%)}	_{1.30s (± 1.75%)}	_~	_1.26s	_1.33s	_{p=0.437 n=6}
_{Total Time}	_{21.08s (± 0.33%)}	_{21.03s (± 0.27%)}	_~	_20.99s	_21.14s	_{p=0.147 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₀	₇₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_226,095	_226,095	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,488	_94,488	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,740k (± 0.02%)}	_{371,708k (± 0.04%)}	_~	_371,573k	_371,949k	_{p=0.378 n=6}
_{Parse Time}	_{3.60s (± 0.46%)}	_{3.59s (± 0.83%)}	_~	_3.55s	_3.64s	_{p=0.366 n=6}
_{Bind Time}	_{1.98s (± 0.53%)}	_{2.00s (± 1.91%)}	_~	_1.95s	_2.06s	_{p=0.221 n=6}
_{Check Time}	_{20.46s (± 0.40%)}	_{20.43s (± 0.40%)}	_~	_20.34s	_20.54s	_{p=0.629 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{26.03s (± 0.34%)}	_{26.02s (± 0.42%)}	_~	_25.87s	_26.12s	_{p=1.000 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,238,377	_3,238,377	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,115,332	_1,115,332	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,306,218k (± 0.01%)}	_{3,306,419k (± 0.01%)}	_~	_3,305,855k	_3,306,866k	_{p=0.471 n=6}
_{Parse Time}	_{14.14s (± 0.29%)}	_{14.12s (± 0.57%)}	_~	_14.02s	_14.24s	_{p=0.630 n=6}
_{Bind Time}	_{4.64s (± 2.72%)}	_{4.55s (± 0.36%)}	_~	_4.53s	_4.57s	_{p=0.250 n=6}
_{Check Time}	_{89.27s (± 2.40%)}	_{88.28s (± 1.96%)}	_~	_87.15s	_91.72s	_{p=0.298 n=6}
_{Emit Time}	_{28.23s (± 3.06%)}	_{27.36s (± 8.04%)}	_~	_23.19s	_29.24s	_{p=0.936 n=6}
_{Total Time}	_{136.28s (± 1.67%)}	_{134.32s (± 0.96%)}	_~	_133.22s	_136.07s	_{p=0.128 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_291,595	_291,595	_~	_~	_~	_{p=1.000 n=6}
_Types	_118,971	_118,971	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{445,417k (± 0.01%)}	_{445,401k (± 0.03%)}	_~	_445,252k	_445,636k	_{p=0.689 n=6}
_{Parse Time}	_{4.10s (± 0.57%)}	_{4.11s (± 1.03%)}	_~	_4.07s	_4.17s	_{p=0.871 n=6}
_{Bind Time}	_{1.78s (± 0.77%)}	_{1.78s (± 1.73%)}	_~	_1.73s	_1.81s	_{p=0.565 n=6}
_{Check Time}	_{18.82s (± 0.34%)}	_{18.84s (± 0.22%)}	_~	_18.79s	_18.90s	_{p=0.422 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.71s (± 0.22%)}	_{24.73s (± 0.32%)}	_~	_24.67s	_24.88s	_{p=1.000 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_555,050	_555,050	_~	_~	_~	_{p=1.000 n=6}
_Types	_186,115	_186,115	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{494,020k (± 0.01%)}	_{494,043k (± 0.00%)}	_~	_494,001k	_494,072k	_{p=0.378 n=6}
_{Parse Time}	_{3.42s (± 0.61%)}	_{3.43s (± 0.48%)}	_~	_3.40s	_3.44s	_{p=0.744 n=6}
_{Bind Time}	_{1.18s (± 0.44%)}	_{1.18s (± 1.48%)}	_~	_1.15s	_1.20s	_{p=0.437 n=6}
_{Check Time}	_{19.56s (± 0.40%)}	_{19.58s (± 0.25%)}	_~	_19.52s	_19.64s	_{p=0.462 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.17s (± 0.38%)}	_{24.19s (± 0.20%)}	_~	_24.13s	_24.24s	_{p=0.147 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2025-01-11T16:07:38Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/60950/merge:

Everything looks good!

jakebailey

This feels right, but @andrewbranch you self assigned so I assume you wanted to look?

Fixed an issue with for statement's incrementor missing continue's co…

1a6ce69

…ntrol flow information

typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Jan 11, 2025

andrewbranch self-assigned this Jan 16, 2025

jakebailey approved these changes Jan 18, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed an issue with for statement's incrementor missing continue's control flow information #60950

Fixed an issue with for statement's incrementor missing continue's control flow information #60950

Andarist commented Jan 11, 2025

jakebailey commented Jan 11, 2025

typescript-bot commented Jan 11, 2025 •

edited

Loading

typescript-bot commented Jan 11, 2025

typescript-bot commented Jan 11, 2025

typescript-bot commented Jan 11, 2025

tsc

typescript-bot commented Jan 11, 2025

jakebailey left a comment

Fixed an issue with for statement's incrementor missing continue's control flow information #60950

Are you sure you want to change the base?

Fixed an issue with for statement's incrementor missing continue's control flow information #60950

Conversation

Andarist commented Jan 11, 2025

jakebailey commented Jan 11, 2025

typescript-bot commented Jan 11, 2025 • edited Loading

typescript-bot commented Jan 11, 2025

typescript-bot commented Jan 11, 2025

typescript-bot commented Jan 11, 2025

tsc

typescript-bot commented Jan 11, 2025

jakebailey left a comment

Choose a reason for hiding this comment

typescript-bot commented Jan 11, 2025 •

edited

Loading