Check if for-of iterated element types are disposable when using `using` declarations #60354

Andarist · 2024-10-27T22:23:36Z

fixes #60348

cc @rbuckton

…ng` declarations

jakebailey · 2024-10-28T18:21:48Z

@typescript-bot test it

(not that there are a major number of these in the wild, or even using in general yet)

jakebailey · 2024-10-28T19:36:30Z

@typescript-bot test it

typescript-bot · 2024-10-28T19:36:34Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-10-28T19:54:49Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/60354/merge:

Everything looks good!

typescript-bot · 2024-10-28T19:59:37Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-10-28T20:16:02Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₁	₃₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,340	_62,340	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,379	_50,379	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{195,832k (± 0.72%)}	_{196,434k (± 0.08%)}	_~	_196,140k	_196,588k	_{p=0.575 n=6}
_{Parse Time}	_{1.61s (± 1.20%)}	_{1.58s (± 1.77%)}	_~	_1.53s	_1.61s	_{p=0.076 n=6}
_{Bind Time}	_{0.87s (± 1.74%)}	_{0.87s (± 0.63%)}	_~	_0.86s	_0.87s	_{p=0.868 n=6}
_{Check Time}	_{11.73s (± 0.18%)}	_{11.76s (± 0.44%)}	_~	_11.66s	_11.80s	_{p=0.077 n=6}
_{Emit Time}	_{3.34s (± 2.27%)}	_{3.32s (± 3.27%)}	_~	_3.24s	_3.54s	_{p=0.414 n=6}
_{Total Time}	_{17.54s (± 0.38%)}	_{17.54s (± 0.58%)}	_~	_17.44s	_17.73s	_{p=0.688 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₃₃	₃₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_947,886	_947,886	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,840	_410,840	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,224,798k (± 0.01%)}	_{1,224,795k (± 0.00%)}	_~	_1,224,685k	_1,224,852k	_{p=0.810 n=6}
_{Parse Time}	_{8.09s (± 0.81%)}	_{8.11s (± 1.09%)}	_~	_7.98s	_8.19s	_{p=0.228 n=6}
_{Bind Time}	_{2.28s (± 0.73%)}	_{2.27s (± 1.13%)}	_~	_2.24s	_2.31s	_{p=0.746 n=6}
_{Check Time}	_{37.85s (± 0.30%)}	_{37.94s (± 0.32%)}	_~	_37.76s	_38.13s	_{p=0.173 n=6}
_{Emit Time}	_{18.29s (± 0.44%)}	_{18.29s (± 0.52%)}	_~	_18.20s	_18.42s	_{p=0.810 n=6}
_{Total Time}	_{66.51s (± 0.17%)}	_{66.63s (± 0.29%)}	_~	_66.43s	_66.98s	_{p=0.228 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,494,603	_2,494,603	_~	_~	_~	_{p=1.000 n=6}
_Types	_908,300	_908,300	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,307,415k (± 0.01%)}	_{2,307,320k (± 0.01%)}	_~	_2,307,126k	_2,307,467k	_{p=0.230 n=6}
_{Parse Time}	_{11.19s (± 0.67%)}	_{11.20s (± 0.35%)}	_~	_11.15s	_11.25s	_{p=0.936 n=6}
_{Bind Time}	_{2.61s (± 0.71%)}	_{2.64s (± 0.88%)}	_~	_2.60s	_2.66s	_{p=0.105 n=6}
_{Check Time}	_{90.84s (± 1.70%)}	_{91.47s (± 1.97%)}	_~	_89.06s	_93.79s	_{p=0.689 n=6}
_{Emit Time}	_{0.35s (± 1.17%)}	_{0.35s (± 2.14%)}	_~	_0.34s	_0.36s	_{p=0.389 n=6}
_{Total Time}	_{104.99s (± 1.53%)}	_{105.66s (± 1.70%)}	_~	_103.24s	_107.92s	_{p=0.689 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,258,044	_1,258,086	_{+42 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,229	_266,247	_{+18 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{3,147,088k (± 0.03%)}	_{3,147,144k (± 0.03%)}	_~	_3,145,928k	_3,149,044k	_{p=0.936 n=6}
_{Parse Time}	_{6.65s (± 1.14%)}	_{6.65s (± 0.31%)}	_~	_6.62s	_6.67s	_{p=0.810 n=6}
_{Bind Time}	_{2.29s (± 4.02%)}	_{2.33s (± 1.19%)}	_~	_2.29s	_2.36s	_{p=0.469 n=6}
_{Check Time}	_{43.07s (± 0.34%)}	_{43.19s (± 0.34%)}	_~	_43.01s	_43.35s	_{p=0.336 n=6}
_{Emit Time}	_{3.48s (± 1.70%)}	_{3.53s (± 1.43%)}	_~	_3.44s	_3.57s	_{p=0.128 n=6}
_{Total Time}	_{55.49s (± 0.19%)}	_{55.69s (± 0.32%)}	_~	_55.41s	_55.86s	_{p=0.128 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,258,044	_1,258,086	_{+42 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,229	_266,247	_{+18 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,672,426k (±10.44%)}	_{2,620,000k (±11.19%)}	_~	_2,498,969k	_3,218,977k	_{p=0.378 n=6}
_{Parse Time}	_{8.29s (± 1.39%)}	_{8.19s (± 1.64%)}	_~	_8.08s	_8.45s	_{p=0.091 n=6}
_{Bind Time}	_{2.67s (± 1.46%)}	_{2.68s (± 2.37%)}	_~	_2.58s	_2.77s	_{p=0.748 n=6}
_{Check Time}	_{53.26s (± 0.50%)}	_{53.68s (± 0.78%)}	_~	_53.35s	_54.50s	_{p=0.128 n=6}
_{Emit Time}	_{4.41s (± 2.18%)}	_{4.41s (± 3.72%)}	_~	_4.25s	_4.64s	_{p=1.000 n=6}
_{Total Time}	_{68.63s (± 0.34%)}	_{68.96s (± 0.78%)}	_~	_68.50s	_69.90s	_{p=0.230 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_261,754	_261,774	_{+20 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_106,477	_106,493	_{+16 (+ 0.02%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{438,828k (± 0.01%)}	_{438,925k (± 0.02%)}	_{+97k (+ 0.02%)}	_438,863k	_439,061k	_{p=0.013 n=6}
_{Parse Time}	_{4.38s (± 0.93%)}	_{4.38s (± 1.06%)}	_~	_4.34s	_4.45s	_{p=1.000 n=6}
_{Bind Time}	_{1.61s (± 0.76%)}	_{1.61s (± 0.47%)}	_~	_1.60s	_1.62s	_{p=0.555 n=6}
_{Check Time}	_{23.38s (± 0.34%)}	_{23.48s (± 0.30%)}	_~	_23.39s	_23.59s	_{p=0.065 n=6}
_{Emit Time}	_{1.91s (± 0.66%)}	_{1.91s (± 1.13%)}	_~	_1.89s	_1.95s	_{p=1.000 n=6}
_{Total Time}	_{31.29s (± 0.37%)}	_{31.39s (± 0.40%)}	_~	_31.28s	_31.60s	_{p=0.128 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₆₈	₆₈	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,919	_225,919	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,415	_94,415	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,141k (± 0.04%)}	_{371,093k (± 0.01%)}	_~	_371,049k	_371,143k	_{p=0.688 n=6}
_{Parse Time}	_{2.89s (± 1.23%)}	_{2.92s (± 1.35%)}	_~	_2.86s	_2.98s	_{p=0.745 n=6}
_{Bind Time}	_{1.59s (± 1.85%)}	_{1.61s (± 1.22%)}	_~	_1.58s	_1.64s	_{p=0.370 n=6}
_{Check Time}	_{16.39s (± 0.33%)}	_{16.35s (± 0.24%)}	_~	_16.31s	_16.40s	_{p=0.261 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.88s (± 0.41%)}	_{20.88s (± 0.27%)}	_~	_20.77s	_20.92s	_{p=0.872 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,128,472	_3,128,472	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,078,305	_1,078,305	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,219,965k (± 0.01%)}	_{3,219,985k (± 0.02%)}	_~	_3,219,338k	_3,220,691k	_{p=0.810 n=6}
_{Parse Time}	_{11.58s (± 0.46%)}	_{11.60s (± 0.54%)}	_~	_11.51s	_11.67s	_{p=0.685 n=6}
_{Bind Time}	_{3.73s (± 2.05%)}	_{3.70s (± 0.24%)}	_~	_3.69s	_3.71s	_{p=1.000 n=6}
_{Check Time}	_{72.03s (± 0.26%)}	_{72.06s (± 0.32%)}	_~	_71.64s	_72.29s	_{p=0.748 n=6}
_{Emit Time}	_{22.98s (± 1.34%)}	_{21.76s (± 9.57%)}	_~	_19.04s	_23.30s	_{p=0.810 n=6}
_{Total Time}	_{110.32s (± 0.33%)}	_{109.12s (± 1.85%)}	_~	_106.43s	_110.63s	_{p=0.810 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_286,866	_286,866	_~	_~	_~	_{p=1.000 n=6}
_Types	_116,245	_116,245	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{437,893k (± 0.01%)}	_{437,926k (± 0.02%)}	_~	_437,824k	_438,044k	_{p=0.378 n=6}
_{Parse Time}	_{3.29s (± 0.46%)}	_{3.28s (± 0.54%)}	_~	_3.27s	_3.31s	_{p=0.866 n=6}
_{Bind Time}	_{1.46s (± 0.35%)}	_{1.47s (± 0.35%)}	_~	_1.46s	_1.47s	_{p=0.311 n=6}
_{Check Time}	_{15.50s (± 0.56%)}	_{15.53s (± 0.42%)}	_~	_15.46s	_15.62s	_{p=0.748 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.25s (± 0.39%)}	_{20.29s (± 0.36%)}	_~	_20.19s	_20.37s	_{p=0.521 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_543,130	_543,130	_~	_~	_~	_{p=1.000 n=6}
_Types	_181,889	_181,889	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{485,546k (± 0.02%)}	_{485,477k (± 0.02%)}	_~	_485,283k	_485,548k	_{p=0.378 n=6}
_{Parse Time}	_{3.37s (± 0.45%)}	_{3.37s (± 0.55%)}	_~	_3.35s	_3.40s	_{p=0.744 n=6}
_{Bind Time}	_{1.18s (± 0.46%)}	_{1.19s (± 0.75%)}	_~	_1.18s	_1.20s	_{p=0.341 n=6}
_{Check Time}	_{19.12s (± 0.35%)}	_{19.25s (± 1.44%)}	_~	_19.08s	_19.81s	_{p=0.520 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{23.67s (± 0.27%)}	_{23.81s (± 1.24%)}	_~	_23.66s	_24.41s	_{p=0.467 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-10-28T21:19:23Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/60354/merge:

Everything looks good!

rbuckton · 2024-11-01T19:57:28Z

src/compiler/checker.ts

@@ -44058,6 +44058,34 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
        return type === autoType ? anyType : type === autoArrayType ? anyArrayType : type;
    }

+    function checkIfUsingDisposables(declaration: Declaration, type: Type) {


This check would be handled by checkVariableLikeDeclaration were it not for the fact that const initializer in that function results in undefined. It seems like we could fit this into that function as an else if case for if (initializer) to avoid repeating the same logic just for for..of.

Something like:

let errorNode: Node | undefined; let initializerType: Type | undefined; if (initializer) { const isJSObjectLiteralInitializer = ...; if (!isJSObjectLiteralInitializer && node.parent.parent.kind !== SyntaxKind.ForInStatement) { errorNode = initializer; initializerType = checkExpressionCached(initializer); checkTypeAssignableToAndOptionallyElaborate(initializerType, type, node, initializer, /*headMessage*/ undefined); } } else if (node.parent.parent.kind === SyntaxKind.ForOfStatement) { errorNode = (node.parent.parent as ForOfStatement).expression; initializerType = checkRightHandSideOfForOf(node.parent.parent as ForOfStatement); } if (initializerType && errorNode) { const blockScopeKind = getCombinedNodeFlagsCached(node) & NodeFlags.BlockScoped; ... }

Check if for-of iterated element types are disposable when using `usi…

fe2b5d4

…ng` declarations

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Oct 27, 2024

move shared code to an util

ec16e39

rbuckton requested changes Nov 1, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Check if for-of iterated element types are disposable when using `using` declarations #60354

Check if for-of iterated element types are disposable when using `using` declarations #60354

Andarist commented Oct 27, 2024

jakebailey commented Oct 28, 2024

jakebailey commented Oct 28, 2024

typescript-bot commented Oct 28, 2024 •

edited

Loading

typescript-bot commented Oct 28, 2024

typescript-bot commented Oct 28, 2024

typescript-bot commented Oct 28, 2024

tsc

typescript-bot commented Oct 28, 2024

rbuckton Nov 1, 2024

Check if for-of iterated element types are disposable when using using declarations #60354

Are you sure you want to change the base?

Check if for-of iterated element types are disposable when using using declarations #60354

Conversation

Andarist commented Oct 27, 2024

jakebailey commented Oct 28, 2024

jakebailey commented Oct 28, 2024

typescript-bot commented Oct 28, 2024 • edited Loading

typescript-bot commented Oct 28, 2024

typescript-bot commented Oct 28, 2024

typescript-bot commented Oct 28, 2024

tsc

typescript-bot commented Oct 28, 2024

rbuckton Nov 1, 2024

Choose a reason for hiding this comment

Check if for-of iterated element types are disposable when using `using` declarations #60354

Check if for-of iterated element types are disposable when using `using` declarations #60354

typescript-bot commented Oct 28, 2024 •

edited

Loading