make qcodes.__version__ lazy #5931
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5931 +/- ##
=======================================
Coverage 67.09% 67.09%
=======================================
Files 352 352
Lines 32035 32035
=======================================
Hits 21494 21494
Misses 10541 10541 ☔ View full report in Codecov by Sentry. |
jenshnielsen
force-pushed
the
jenshnielsen/lazy_version
branch
from
9bd9158
to
27fce61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This speeds up importing qcodes from an editable install with ~ 0.6-0.7 s assuming that you do not actually make use of the
__version__attribute. The downside is that we do lose some of the static typing of this attribute. See inline commentsEdit. Adding a type to
__version__partially resolves this but its probably better to make version an lazily evaluated property and reference that