feat(eslint-config-fluid): Add strict biome-compatible config #22960
Conversation
github-actions
bot
added
area: build
| @@ -20,7 +20,7 @@ module.exports = { | |||
| es2024: false, | |||
| node: true, | |||
| }, | |||
| extends: ["./recommended.js"], | |||
| extends: ["./recommended.js", "biome"], | |||
There was a problem hiding this comment.
Do not merge without reverting this.
There was a problem hiding this comment.
I made this change so it was easier to see the diff between the strict and strict-biome configs via the printed config. Once reviewed I'll revert.
| @@ -24,6 +24,7 @@ | |||
| "print-config:react": "eslint --config ./index.js --print-config ./src/file.tsx > ./printed-configs/react.json", | |||
| "print-config:recommended": "eslint --config ./recommended.js --print-config ./src/file.ts > ./printed-configs/recommended.json", | |||
There was a problem hiding this comment.
No interaction in recommended?
| @@ -20,7 +20,7 @@ module.exports = { | |||
| es2024: false, | |||
| node: true, | |||
| }, | |||
| extends: ["./recommended.js"], | |||
| extends: ["./recommended.js", "biome"], | |||
This change is not about formatting. It's about linting. Eslint 8 is deprecated. Eslint 9 will require work to adopt. I want to explore not using Eslint altogether, or supplementing it with a faster linter (biome, oxlint) to better inform our lint plans for the future. |
By "formatting things" I mean all lint formatting rules. Suggesting that we don't have a special Biome config and instead disable all of these format related rules everywhere. |
Maybe I am misunderstanding. The special Biome config is not disabling formatting rules exclusively. It's disabling lint rules from this list (partially - only the "recommended" rules), which includes stuff like no explicit-any and use-for-of. If you look at the strict printed config diff in this PR you can see all the rules that are getting disabled: https://github.com/microsoft/FluidFramework/pull/22960/files#diff-7c530cc3edf251a186efaba26d97f51273af07d4fc094e7f2ea362a5b0fdb742 |
Hmm. I think the diffs might have been weird when #22959 was outstanding. And I think the title can be interpreted two ways. Could be nice to add some notes to the readme about how to use the new config. I am guessing that Biome needs to be used in conjunction. |
Adds a strict config to the shared eslint package that can be used in projects to use Biome for linting in conjunction with eslint. This config is the same as the strict config, but disables rules that have a Biome equivalent.
To make it easier to see the differences, I also updated the strict config - this will not be merged.