Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi model deployment #208
base: main
Are you sure you want to change the base?
Multi model deployment #208
Changes from 37 commits
4eac006
c68e999
5ce1a92
fa10e19
f9cbd74
8970f4e
517bea8
58dd2b2
bb0d551
e2bb9d5
3823534
6f9b4ad
499b9ad
5419ef6
a70b6de
eea658b
20f0878
c21c31b
f525329
3c0937f
156ac83
38e270e
4d4e0d8
01c8e59
f801b36
fd4e2ed
0a3b7e5
6523c04
06b40f5
96d0dcb
ab41d24
8673a9a
8d09b37
7a136d6
2c6ec08
0cb88a9
7c0ee12
7a956d5
f8cfe28
079807d
ea1e47e
98b6129
daab5e6
84073f9
3ee3410
b4edc2b
6346194
94b6699
710c20b
c2636b7
189e75c
adee843
a145be5
082c05e
3ce77d2
b40ecbd
72dd95c
a4e3d56
4b5bb47
30d2b03
c5d5996
3ae1781
4b8f02f
c51ce37
43479db
e1b6d23
1675bd8
8684a61
56a7fce
fb70c3d
e2cfe8a
1312738
b0f0da4
b78068e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason that these would not be a
dict
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the data is written to the score file it stores the dictionaries of all the deployments, along with the load balancer, model_path, and deployment_tag. The 'deployment' on line 18 in the for loop looks at all of them. So I determine if it is a model by checking if it is a dictionary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check for multiple models if there is no deployment name passed in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we support having separate restful APIs for each deployment in a multi-model deployment? I think it is tied to the load balancer, not the inference servers.