Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New System App Module for easy file systems access #663

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open

New System App Module for easy file systems access #663

Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
3d52a6a
Move to BCApps
IceOnly Feb 29, 2024
62b73a7
Upgrade to BC24
IceOnly Feb 29, 2024
c0276ff
Add Interface changes
IceOnly Mar 1, 2024
7945909
Fix Account Browser
IceOnly Mar 1, 2024
692b8b7
Change application are to new logic
IceOnly Mar 1, 2024
1277528
Fix first batch of code review suggestions
IceOnly Mar 1, 2024
ca7455a
Add File Pagination Facade
IceOnly Mar 1, 2024
ae719dd
Reduce code in file browser page
IceOnly Mar 1, 2024
8d8eee9
Use only test lib for internal access
IceOnly Mar 1, 2024
4258a0b
Fix variable names
IceOnly Mar 1, 2024
30a0622
Add review suggestions
IceOnly Apr 10, 2024
5b3228a
Solve name and id conflicts
IceOnly Apr 10, 2024
0cfd765
Fix test
IceOnly Apr 10, 2024
0327220
Fix application areas
IceOnly Jun 10, 2024
0ec94d8
Remove unused label
IceOnly Jun 10, 2024
6f742e4
Simplify integer incrementation
IceOnly Jun 10, 2024
33afd83
Sort variables
IceOnly Jun 10, 2024
f701d9f
Add Init to AddEntry
IceOnly Jun 10, 2024
c3cd8b5
Change tooltip to code review suggestion
IceOnly Jun 10, 2024
a53d936
Solve code review comments
IceOnly Aug 23, 2024
e6bf344
Solve code review suggestions 2
IceOnly Aug 23, 2024
e077767
Use labels for telemetry
IceOnly Aug 23, 2024
f1c251a
Fix code review suggestions
IceOnly Aug 26, 2024
73ed292
Remove useless internal attributes
IceOnly Aug 27, 2024
017b7d0
Refactored to media only
IceOnly Aug 30, 2024
4e5968e
Fix tooltips
IceOnly Sep 17, 2024
5fd8fc8
Revert GetIsLegacyActionBarEnabled change
IceOnly Sep 17, 2024
ecf81b5
Renumber Test Lib
IceOnly Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/System Application/App/File System/src/Account/FileAccountWizard.Page.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@
FreezeColumn = Name;
Editable = false;

field(Logo; Rec.Logo)

Check failure on line 129 in src/System Application/App/File System/src/Account/FileAccountWizard.Page.al

View workflow job for this annotation

GitHub Actions / Build System Application and Tools (Translated) / System Application and Tools (Translated) 

AW0009 Using a Blob with subtype Bitmap on a page field is deprecated. Instead use the Media/MediaSet data types.

Check failure on line 129 in src/System Application/App/File System/src/Account/FileAccountWizard.Page.al

View workflow job for this annotation

GitHub Actions / Build System Application and Tools (Clean) / System Application and Tools (Clean) 

AW0009 Using a Blob with subtype Bitmap on a page field is deprecated. Instead use the Media/MediaSet data types.

Check failure on line 129 in src/System Application/App/File System/src/Account/FileAccountWizard.Page.al

View workflow job for this annotation

GitHub Actions / Build System Application and Tools (Default) / System Application and Tools (Default) 

AW0009 Using a Blob with subtype Bitmap on a page field is deprecated. Instead use the Media/MediaSet data types.
{
Caption = ' ';
Editable = false;
Expand Down Expand Up @@ -400,15 +400,17 @@
FeatureTelemetry: Codeunit "Feature Telemetry";
AccountWasRegistered: Boolean;
ConnectorSucceeded: Boolean;
CTHTok: Label '%1 account has been setup.', Locked = true;
IceOnly marked this conversation as resolved.
Show resolved Hide resolved
CTITok: Label '%1 account has failed to setup. Error: %2', Locked = true;
begin
ConnectorSucceeded := TryRegisterAccount(AccountWasRegistered);

if AccountWasRegistered then begin
FeatureTelemetry.LogUptake('0000CTF', 'File Access', Enum::"Feature Uptake Status"::"Set up");
Session.LogMessage('0000CTH', Format(Rec.Connector) + ' account has been setup.', Verbosity::Normal, DataClassification::SystemMetadata, TelemetryScope::ExtensionPublisher, 'Category', FileCategoryLbl);
Session.LogMessage('0000CTH', StrSubstNo(CTHTok, Rec.Connector), Verbosity::Normal, DataClassification::SystemMetadata, TelemetryScope::ExtensionPublisher, 'Category', FileCategoryLbl);
IceOnly marked this conversation as resolved.
Show resolved Hide resolved
NextStep(false);
end else begin
Session.LogMessage('0000CTI', StrSubstNo(Format(Rec.Connector) + ' account has failed to setup. Error: %1', GetLastErrorCallStack()), Verbosity::Normal, DataClassification::SystemMetadata, TelemetryScope::ExtensionPublisher, 'Category', FileCategoryLbl);
Session.LogMessage('0000CTI', StrSubstNo(CTITok, Rec.Connector, GetLastErrorCallStack()), Verbosity::Normal, DataClassification::SystemMetadata, TelemetryScope::ExtensionPublisher, 'Category', FileCategoryLbl);
NextStep(true);
end;

Expand Down
Loading