[Document Sharing] Add cancelled parameter and use in word template edit after merge #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NKarolak
reviewed
Jan 4, 2024
src/System Application/App/Document Sharing/src/DocumentSharing.Table.al
Outdated
Show resolved
Hide resolved
…g.Table.al Co-authored-by: Natalie Karolak <[email protected]>
IhorHandziuk
previously approved these changes
Jan 4, 2024
msft-sam
reviewed
Jan 4, 2024
src/System Application/App/Document Sharing/src/DocumentSharingImpl.Codeunit.al
Outdated
Show resolved
Hide resolved
…len/documentsharingcancelled
StefanSosic
reviewed
Jun 23, 2024
| @@ -609,6 +609,10 @@ codeunit 9988 "Word Template Impl." | |||
| TempDocumentSharing.Insert(); | |||
|
|
|||
| DocumentSharing.Share(TempDocumentSharing); | |||
|
|
|||
| if TempDocumentSharing.State = TempDocumentSharing.State::Cancelled then | |||
There was a problem hiding this comment.
Would be nice to cover also this one scenario in tests
\src\System Application\Test\Word Templates\src*
I would say codeunit 130443 "Word Templates Test" is good fit for it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For document sharing, add a state parameter that is set when import of file is cancelled.
Use the state parameter to cancel execution in Word Templates
EditDocumentAfterMergeif import is cancelled. This will ensure that attachments are not set to unique in Interaction Templates whenever the import is cancelled.Work Item(s)
Fixes AB#494806