Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RSA.Codeunit.al #2255

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update RSA.Codeunit.al #2255

wants to merge 2 commits into from

Conversation

MattiLE
Copy link
Contributor

@MattiLE MattiLE commented Oct 24, 2024

Summary

Overload for ToSecretXmlString to work with a private key in a pem file.

Work Item(s)

Fixes #866

Fixes AB#555892
Fixes AB#524188

@MattiLE MattiLE requested a review from a team as a code owner October 24, 2024 13:37
@github-actions github-actions bot added AL: System Application From Fork Pull request is coming from a fork labels Oct 24, 2024
@JesperSchulz JesperSchulz added Linked Issue is linked to a Azure Boards work item Integration GitHub request for Integration area labels Oct 25, 2024
@github-actions github-actions bot added this to the Version 26.0 milestone Oct 25, 2024
Copy link
Contributor

@JesperSchulz JesperSchulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't compile.
Also, should the private key not be a secret text, rather than text?

@JesperSchulz JesperSchulz self-assigned this Oct 25, 2024
@JesperSchulz
Copy link
Contributor

@MattiLE, compilation still fails: Error: AL0133 Argument 1: cannot convert from 'SecretText' to 'DotNet "System.ReadOnlySpan<System.Char>"'. Could you take another look? 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AL: System Application From Fork Pull request is coming from a fork Integration GitHub request for Integration area Linked Issue is linked to a Azure Boards work item
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BC Idea]: Extend BC System APP with RSASSA-PSS algorithm
2 participants