Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[25.x][Number Series Copilot] Bug Fixes in Intent Understanding and Field V… #2251

Merged

Conversation

JesperSchulz
Copy link
Contributor

@JesperSchulz JesperSchulz commented Oct 23, 2024

…alidation (#2111)

Summary

This PR addresses three critical bugs in the Number Series Copilot:

  1. Bug 1: Incorrect Intent Mapping for "Generate" Command
  • The system was misinterpreting the "generate" command, often preparing Number Series for the next period instead of creating a new one. The fix involves updating the tools definition and prompt to clarify the distinction between creating new Number Series and generating Number Series for the next period.
  1. Bug 2: Incorrect Field Check for Existing Number Series
  • The system was incorrectly performing checks on all fields for existing Number Series. The fix modifies the behavior to exclude pre-existing Number Series from the field validation checks, ensuring that only mandatory fields are validated for AI generated series.
  1. Bug 3: Blank Fields Causing Validation Errors
  • The system was generating Number Series without values for optional fields, causing validation errors. The fix refines the validation logic so that only mandatory fields are checked, allowing optional fields to remain blank if necessary.

Steps to Implement:

  1. Refactor the LLM prompt and tools definition to improve the understanding of user intent between creating and preparing Number Series for different periods.
  2. Update the logic to exclude field checks for existing Number Series and restrict checks to mandatory fields.

Acceptance Criteria:

  • Users can create Number Series without mistakenly triggering next-period Number Series generation when using the word "generate."
  • Existing Number Series are excluded from unnecessary checks, and only mandatory fields are validated for new series.

These fixes aim to enhance the accuracy and reliability of the Number Series Copilot, ensuring it correctly interprets user commands and validates the necessary fields.

Work Item(s)

Fixes #2106

Fixes AB#555649

…alidation (#2111)

<!-- Thank you for submitting a Pull Request. If you're new to
contributing to BCApps please read our pull request guideline below
* https://github.com/microsoft/BCApps/Contributing.md
-->

#### Summary <!-- Provide a general summary of your changes -->

This PR addresses three critical bugs in the Number Series Copilot:

1. **Bug 1: Incorrect Intent Mapping for "Generate" Command**
- The system was misinterpreting the "generate" command, often preparing
Number Series for the next period instead of creating a new one. The fix
involves updating the tools definition and prompt to clarify the
distinction between creating new Number Series and generating Number
Series for the next period.

2. **Bug 2: Incorrect Field Check for Existing Number Series**
- The system was incorrectly performing checks on all fields for
existing Number Series. The fix modifies the behavior to exclude
pre-existing Number Series from the field validation checks, ensuring
that only mandatory fields are validated for AI generated series.

3. **Bug 3: Blank Fields Causing Validation Errors**
- The system was generating Number Series without values for optional
fields, causing validation errors. The fix refines the validation logic
so that only mandatory fields are checked, allowing optional fields to
remain blank if necessary.

**Steps to Implement:**

1. Refactor the LLM prompt and tools definition to improve the
understanding of user intent between creating and preparing Number
Series for different periods.
2. Update the logic to exclude field checks for existing Number Series
and restrict checks to mandatory fields.

**Acceptance Criteria:**

- Users can create Number Series without mistakenly triggering
next-period Number Series generation when using the word "generate."
- Existing Number Series are excluded from unnecessary checks, and only
mandatory fields are validated for new series.

These fixes aim to enhance the accuracy and reliability of the Number
Series Copilot, ensuring it correctly interprets user commands and
validates the necessary fields.


#### Work Item(s) <!-- Add the issue number here after the #. The issue
needs to be open and approved. Submitting PRs with no linked issues or
unapproved issues is highly discouraged. -->

Fixes #2106 

Fixes
[AB#550892](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/550892),
[AB#544073](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/544073)
@JesperSchulz JesperSchulz requested review from a team as code owners October 23, 2024 10:17
@github-actions github-actions bot added this to the Version 25.1 milestone Oct 23, 2024
@JesperSchulz JesperSchulz linked an issue Oct 23, 2024 that may be closed by this pull request
1 task
@JesperSchulz JesperSchulz merged commit 954d04a into releases/25.x Oct 23, 2024
20 of 23 checks passed
@JesperSchulz JesperSchulz deleted the bugs/550892-25xAddV2PromptsToGenNoSeries branch October 23, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: [Number Series Copilot] Bug fixes
4 participants