-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: svelte 5 port and documentation field improvements #305
Open
mgreminger
wants to merge
97
commits into
main
Choose a base branch
from
svelte5
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest version of carbon components supports svelte 5
Reference screenshots will still need to be updated
The new version of carbon components fixes a small layout missalignment for the toolbar buttons
This should fix the insert sheet regression
This reverts commit f60eaac.
Allows keyboard to be made reactive. Needed for the selectedTab property
This was the wrong place to put the reactivity
Has some performance improvements over prevoius version
Brakes other things, all cell types will need to be ported before all tests will pass. Having non-runes and runes components access the same stores causes reactivity issues for the non-runes components.
Change $effect to $derived.by
This was
linked to
issues
Jan 26, 2025
Prevents cache from blocking updates in CF pages builds
This makes the latex copied to the clipboard compatible with the new documentation cell formula functionality
Unfortunately, colors not supported in docx and pdf export since markdown doesn't support text colors
Also checks for presistence when saving and reopening
Overflow was causing issue with firefox test
Double up newlines and make sure field ends with two newlines so that resulting document files better match the line breaks in the quill field
Provides better control of min font scale and makes math field selectable and copyable. Also adds alt-= keyboard shortuct to insert formula.
Add formula and other quill shortcuts and categorize shortcuts. Also, add calc shortcuts that were previously undocumented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires latest carbon svelte components