Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dataset and import data file #6

Merged
merged 4 commits into from
Feb 17, 2025
Merged

Added dataset and import data file #6

merged 4 commits into from
Feb 17, 2025

Conversation

Nathaniel-github
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 61.68%. Comparing base (2bfb7d1) to head (9b471a6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cellcommunicationpf2/import_data.py 0.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
- Coverage   67.37%   61.68%   -5.69%     
==========================================
  Files           4        5       +1     
  Lines         141      154      +13     
==========================================
  Hits           95       95              
- Misses         46       59      +13     
Flag Coverage Δ
unittests 61.68% <0.00%> (-5.69%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewram4287
Copy link
Collaborator

@Nathaniel-github Awesome, this looks good to me since we don't want to upload the data directly.

cellcommunicationpf2/import_data.py Show resolved Hide resolved
cellcommunicationpf2/import_data.py Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@Nathaniel-github
Copy link
Collaborator Author

@aarmey I reworked the code to just use a standard request call but I am noticing that the resulting h5ad file is roughly 1/3 of the size of the scanpy file. Not sure if that means anything but I double checked downloading the file on my local machine through chrome and it agrees with the size of the new smaller file so not really sure what is going on with the scanpy import that makes the file bigger.

aarmey

This comment was marked as resolved.

@Nathaniel-github Nathaniel-github merged commit 330131d into main Feb 17, 2025
1 check failed
@Nathaniel-github Nathaniel-github deleted the data branch February 17, 2025 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants