Fix Scoary-2 integration. #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scoary-2 uses a database to store scores for topologies and it caches the connection and cursor to that database when scoary gets loaded. This leads to issues for the integration as the SQL object might be used in a different thread than it was created in. We fix it here by resetting the connection before calling scoary.
njohner
force-pushed
the
nj/fix_scoary_integartion
branch
from
1afc12b to
861a000
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scoary-2 uses a database to store scores for topologies and it caches the connection and cursor to that database when scoary gets loaded. This leads to issues for the integration as the SQL object might be used in a different thread than it was created in. We fix it here by resetting the connection before calling scoary.
Note that I have also opened a PR in the scoary repo, so the current fix would not be necessary anymore if it gets fixed there and a new release is made...
Checklist