Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code block unreachable #659

Merged
merged 1 commit into from
Aug 25, 2024
Merged

Conversation

wnagele
Copy link
Contributor

@wnagele wnagele commented Aug 25, 2024

Cleaning up a code block that clearly will never execute.

Copy link

codecov bot commented Aug 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.66%. Comparing base (abf9e96) to head (e725292).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #659      +/-   ##
==========================================
+ Coverage   61.63%   61.66%   +0.03%     
==========================================
  Files          24       24              
  Lines        3597     3592       -5     
==========================================
- Hits         2217     2215       -2     
+ Misses       1380     1377       -3     
Flag Coverage Δ
unittests 61.66% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ianmcorvidae
Copy link
Contributor

Good catch, thanks!

@ianmcorvidae ianmcorvidae merged commit bcce568 into meshtastic:master Aug 25, 2024
11 checks passed
@wnagele wnagele deleted the unreachable_code branch August 25, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants