Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method to be able to send heartbeat #658

Merged
merged 2 commits into from
Aug 25, 2024

Conversation

wnagele
Copy link
Contributor

@wnagele wnagele commented Aug 25, 2024

Allows to check if the connection is still alive and working. I need this in a case where other calls are only happening fairly infrequently and a broken connection would only show up much later.

Copy link

codecov bot commented Aug 25, 2024

Codecov Report

Attention: Patch coverage is 11.11111% with 8 lines in your changes missing coverage. Please review.

Project coverage is 61.64%. Comparing base (abf9e96) to head (d77335c).
Report is 3 commits behind head on master.

Files Patch % Lines
meshtastic/mesh_interface.py 11.11% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #658      +/-   ##
==========================================
+ Coverage   61.63%   61.64%   +0.01%     
==========================================
  Files          24       24              
  Lines        3597     3598       +1     
==========================================
+ Hits         2217     2218       +1     
  Misses       1380     1380              
Flag Coverage Δ
unittests 61.64% <11.11%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ianmcorvidae
Copy link
Contributor

This looks good to me (we can ignore the code coverage aspect, I think)! I know a few others have been interested in something like this being split out for easy use.

@ianmcorvidae ianmcorvidae merged commit b9d8050 into meshtastic:master Aug 25, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants