chore: Convert StateDB to TS #6296
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* develop: Added changeset. refactor: handle StateDB `.extract()` properly
🦋 Changeset detectedLatest commit: 5abda14 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
commit: |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6296 +/- ##
=======================================
Coverage 4.46% 4.46%
=======================================
Files 384 384
Lines 54264 54259 -5
Branches 623 597 -26
=======================================
Hits 2425 2425
+ Misses 51839 51834 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
* develop: chore: Remove deprecated rule chore(deps): update eslint chore: Add tslib chore(deps): update eslint chore: Minor refactor chore: Update actions/cache chore: Update actions/cache added changeset added test cases to check state diagram direction fix: CodeQL double escape warning refatored code chore(deps): update eslint Fix: state diagram default direction update [autofix.ci] apply automated fixes fix(deps): update all patch dependencies
sidharthv96
force-pushed
the
sidv/stateDB-ts
branch
from
f48e5c5 to
bb4b92a
Compare
saurabhg772244
approved these changes
Feb 22, 2025
| labelStyle: '', | ||
| shape: SHAPE_NOTE, | ||
| label: parsedItem.note.text, | ||
| cssClasses: CSS_DIAGRAM_NOTE, | ||
| // useHtmlLabels: false, | ||
| cssStyles: [], | ||
| cssCompilesStyles: [], | ||
| cssCompiledStyles: [], |
There was a problem hiding this comment.
Have we made sure this change will not affect anything?
| id: itemId + NOTE_ID + '-' + graphItemCount, | ||
| domId: stateDomId(itemId, graphItemCount, NOTE), | ||
| type: newNode.type, | ||
| isGroup: newNode.type === 'group', | ||
| padding: getConfig().flowchart.padding, | ||
| padding: getConfig().flowchart!.padding, |
There was a problem hiding this comment.
I wonder if there is a way to avoid !
There was a problem hiding this comment.
May be add ? instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Summary
Convert stateDB and datafetcher into TS.
📏 Design Decisions
Describe the way your implementation works or what design decisions you made if applicable.
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSIONis used for all new features.pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.