-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Change ClassDB to class based architecture. #6212
Refactor: Change ClassDB to class based architecture. #6212
Conversation
🦋 Changeset detectedLatest commit: 15ffe20 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
commit: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6212 +/- ##
==========================================
- Coverage 4.47% 4.47% -0.01%
==========================================
Files 384 385 +1
Lines 54227 54243 +16
Branches 623 598 -25
==========================================
Hits 2425 2425
- Misses 51802 51818 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To avoid the ESLint @typescript-eslint/unbound-method
errors in the packages/mermaid/src/diagrams/class/classDiagram.spec.ts
file, I'd recommend just adding a comment in the file like /* eslint-disable @typescript-eslint/unbound-method -- Broken for Vitest mocks, see https://github.com/vitest-dev/eslint-plugin-vitest/pull/286 */
…saurabh/refactor/convert-classDb-to-class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cheers for fixing the unit tests, LGTM now!
…saurabh/refactor/convert-classDb-to-class
📑 Summary
diagramObject.db
is called.Resolves #
📏 Design Decisions
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.