-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Iconify support #827
Add Iconify support #827
Conversation
Co-authored-by: Alois Klink <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks perfect to me! Thanks for making all of those changes 😄
Since we copy mermaid-js/mermaid release cycle (except for bugs/security issues), this will only be released the next time Mermaid has a release.
So I'll leave this PR open for a bit in case @MindaugasLaganeckas wants to review the Docker test changes.
Thanks @ynaka81 for the effort. Could you please merge this PR to main branch. We are looking forward for this PR to fix the icons issue. I am getting |
@sumitj18s, I've merged this PR to However, it will only be released officially the next time mermaid-js/mermaid has a release (and there's a slight but unlikely chance that we might change the API/CLI flags before the release). |
Thanks for merging this PR! I'm happy to contribute to this repository. It's totally fine to change the API/CLI flags in a way that the community thinks is easier to use and I'm looking forward to the release. |
📑 Summary
Support Iconify icon packs that are used in
architecture-beta
.Resolves #764, #805
📏 Design Decisions
I have the same issue described in the #764 and #805. I think it makes sense to add the way similar as the comment #764 (comment) to the upstream because it doesn't have any side effect if it's lazy load.
Although it might be reasonable to support any icon packs with a command line option, it would be good to support commonly used
logos
andmdi
first as Markdown Preview Mermaid Support supports them.📋 Tasks
Make sure you
master
branch