Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure the proper metadata are used when stap_a RTP packet sets its marker bit #49

Merged
merged 3 commits into from
Jun 24, 2024

Conversation

varsill
Copy link
Contributor

@varsill varsill commented Jun 18, 2024

This PR:

  • fixes a bug of not setting the marker bit of STAP-A RTP packets if the final NALu of a STAP packet is the last NALu of an access unit

The bugfix updates the metadata in the stap_acc each time a new buffer is processed, so that to make sure that when the stap_acc gets flushed, its the metadata of the final buffer (that might have end_access_unit: true set) that is used in the set_marker function.

@varsill varsill requested a review from mat-hek June 18, 2024 13:20
@mat-hek mat-hek merged commit 84b53dd into master Jun 24, 2024
0 of 3 checks passed
@mat-hek mat-hek deleted the fix_stap_a_marker_bit branch June 24, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants