This repository has been archived by the owner on Jan 23, 2018. It is now read-only.
Add autolink util function to link urls w/o protocol #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm so glad we moved to an established library for all our linking needs. |
|
user experience: ALL THE LINKS ARE FUQT |
|
Really helpful, relevant commentary, guys. Thanks! |
|
@jasonrhodes sorry, I updated my comment with more relevant structure and steps to reproduce |
|
Wanted to do this myself, thanks for taking care of it! |
tec27
added a commit
that referenced
this pull request
Oct 8, 2014
Add autolink util function to link urls w/o protocol
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
twitter-text seems like they have no way of autoLinking to include URLs with no protocl as of now, so this mini hack does the job for the time. Keeping an eye on my PR and will update here if that situtation changes.