Feat/remix recipe #227
Feat/remix recipe #227
Conversation
|
@EarthlingDavey is attempting to deploy a commit to the Measured Team on Vercel. A member of the Team first needs to authorize it. |
|
I'm not sure why, but |
There was a problem hiding this comment.
Thanks @EarthlingDavey! This works beautifully 🙌
I've left some comments.
To get this merged, you'll also need to add the recipe to the create-puck-app templates. You don't need to add all the code, just any handlebars overrides (which will include the package.json - see the next example).
Would also appreciate it if you could add it to the README, below the next recipe.
| // crypto is used by packages/core/dist/index.js | ||
| // is it possible to not send it to the browser? | ||
| // for not, we need to polyfill it... | ||
| browserNodeBuiltinsPolyfill: { modules: { crypto: true } }, |
There was a problem hiding this comment.
This is a bit awkward. We can hopefully remove this when we deal with #112
| */ | ||
| // const matches = useMatches(); | ||
| // const includeScripts = matches.some((match) => match.handle?.hydrate); | ||
|
|
There was a problem hiding this comment.
I'm a bit 50/50 about whether we should include this. It's great, but also bloats the recipe for users that want JS.
Let me have a think on it before we remove it.
View: Untitled Page to Page. Edit & View: Fix TS error
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
# Conflicts: # yarn.lock
remix.config.js update comment re: crypto
|
@chrisvxd thanks for the review. I've worked through them and not touched the disable-js code. I'm not sure about that too. Perhaps that should be stripped but added to an example codebase? |
|
Thanks @EarthlingDavey! I think let's remove the no JS code. The user can figure that out based on the Remix docs. |
There was a problem hiding this comment.
Awesome stuff, thanks @EarthlingDavey. Merging now and will remove the noJS stuff myself in favour of the remix docs.
|
Can't be merged due to conflicts. |
Add remix recipe - I've only touched the
remix/recipefolder. So I don't know if there's extra stuff I need to do to prepare the package for release.It's working fine - but with some TS errors like : #185
Do you mind reviewing, and advising the best way to fix the errors.
I can also remove or amend the devcontainer if needed.
Thanks