Fix base path error #106
Merged
Fix base path error #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
|
Thanks, Chris! I think this makes sense, let's merge and check how the deploy goes. I'll keep an eye on it 👀 |
bsmth
approved these changes
Jan 8, 2024
This comment was marked as outdated.
This comment was marked as outdated.
Nice one, cheers @bsmth! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Live application is failing to load on gh-pages with the following error:
"Loading module from “https://mdn.github.io/assets/index-u64nDbB7.js” was blocked because of a disallowed MIME type (“text/html”).
todo-react
Loading failed for the module with source “https://mdn.github.io/assets/index-u64nDbB7.js”."
This looks to be because the base path is not defined in the vite config.
Fixes #102
Motivation
Additional details
Related issues and pull requests