Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(css): Update synatx for css zoom property #901

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Jan 18, 2025

Description

see comments below

see https://drafts.csswg.org/css-viewport/#propdef-zoom for spec

Motivation

Additional details

Related issues and pull requests

@@ -10832,18 +10832,18 @@
"mdn_url": "https://developer.mozilla.org/docs/Web/CSS/z-index"
},
"zoom": {
"syntax": "normal | reset | <number> | <percentage>",
"syntax": "normal | reset | <number [0,∞]> || <percentage [0,∞]>",
Copy link
Contributor Author

@skyclouds2001 skyclouds2001 Jan 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the syntax for the spec is <number [0,∞]> || <percentage [0,∞]>, while the non-standard normal keyword is supported in chrome, firefox and safari per manually test; the non-standard reset keyword is supported in safari per bcd and manually test

notice since double bar has precedence over the single bar, normal | reset | <number [0,∞]> || <percentage [0,∞]> is equal to normal | reset | [ <number [0,∞]> || <percentage [0,∞]> ]

see also mdn/content#37705

"groups": [
"Microsoft Extensions"
],
"initial": "normal",
"initial": "1",
"appliesto": "allElements",
Copy link
Contributor Author

@skyclouds2001 skyclouds2001 Jan 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while spec says it as all property values of all elements, this should just be all elements

the target for appliesto should should be elements per its defnition

@skyclouds2001 skyclouds2001 marked this pull request as ready for review January 18, 2025 17:02
@skyclouds2001 skyclouds2001 requested a review from a team as a code owner January 18, 2025 17:02
@skyclouds2001 skyclouds2001 requested review from pepelsbey and removed request for a team January 18, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant