Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(css): Remove lack-support, deprecated input-security #863

Merged
merged 5 commits into from
Jan 16, 2025

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Dec 27, 2024

Description

data added in #512

found using https://github.com/skyclouds2001/mdn-tools/blob/master/checks/mdn_url-check.js and reported in https://github.com/skyclouds2001/mdn-tools/blob/master/results/incorrect_mdn_url.json

per spec https://drafts.csswg.org/css-ui/#propdef-input-security, it seems that it'll be removed from spec soon, see also w3c/csswg-drafts#6788 and whatwg/html#7293; also notice that per mdn/browser-compat-data#12822, it only support in safari preview and disabled by default via a runtime flag

Motivation

Additional details

Related issues and pull requests

Relates to mdn/browser-compat-data#12664
Relates to #511
Relates to mdn/content#9422
Relates to mdn/content#10438

@skyclouds2001 skyclouds2001 marked this pull request as ready for review December 27, 2024 16:39
@skyclouds2001 skyclouds2001 requested a review from a team as a code owner December 27, 2024 16:39
@skyclouds2001 skyclouds2001 requested review from bsmth and removed request for a team December 27, 2024 16:39
@skyclouds2001 skyclouds2001 changed the title feat(css): Remove lack-support, will-obsolute, deprecated input-security feat(css): Remove lack-support, deprecated input-security Dec 30, 2024
@bsmth
Copy link
Member

bsmth commented Jan 15, 2025

Thanks a lot, I found the discussions about this really hard to follow, and I had to revisit it a few times to understand the context, but the important piece, like you mentioned, is the spec section:

https://drafts.csswg.org/css-ui/#input-security

So I'm okay with removing this

"CSS Basic User Interface"
],
"initial": "auto",
"appliesto": "sensitiveTextInputs",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also be removing this

./css/properties.schema.json:        "sensitiveTextInputs",

Seems like it's not used anywhere else

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty

@skyclouds2001 skyclouds2001 requested a review from bsmth January 15, 2025 16:17
@bsmth bsmth merged commit 857fe8d into mdn:main Jan 16, 2025
3 checks passed
@skyclouds2001 skyclouds2001 deleted the input-security branch January 16, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants