Function Wizard: create Effects #1649
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, this doesn't build. |
mcallegari
reviewed
Jan 4, 2025
ui/src/palettegenerator.cpp
Outdated
| { | ||
| EFX *efx = new EFX(m_doc); | ||
|
|
||
| QString modeString = (new QString[]{KXMLQLCEFXFixtureModePanTilt, KXMLQLCEFXFixtureModeDimmer, KXMLQLCEFXFixtureModeRGB})[mode]; |
There was a problem hiding this comment.
This is the line that fails to build. Can you just use a QStringList?
|
i fixed it i did not see that EFXFixture has a modeToString function i removed the line and used this function instead |
mcallegari
reviewed
Jan 4, 2025
ui/src/palettegenerator.cpp
Outdated
| @@ -561,6 +630,15 @@ void PaletteGenerator::createFunctions(PaletteGenerator::PaletteType type, | |||
| if (m_redList.size() > 1 && m_greenList.size() == m_redList.size() && m_blueList.size() == m_redList.size()) | |||
| createRGBMatrices(m_redList); | |||
| } | |||
| break; | |||
mcallegari
reviewed
Jan 4, 2025
ui/src/palettegenerator.cpp
Outdated
| @@ -102,6 +104,7 @@ QString PaletteGenerator::typetoString(PaletteGenerator::PaletteType type) | |||
| case Gobos: return tr("Gobo macros"); | |||
| case ColourMacro: return tr("Colour macros"); | |||
| case Animation: return tr("Animations"); | |||
| case Effect: return tr("Effects"); | |||
There was a problem hiding this comment.
Why not "EFX"? Users are used to that term
8-Lambda-8
force-pushed
the
effectsInWizard
branch
from
0d97a33 to
1324743
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I added the possibility to create Effects with the Function Wizard
What types of effects arc creates is determined by the fixture capabilities (Dimmer, RGB, Position).
for each type a normal and a staggered version (start offset spread equally) will be created.