Solution #244
Open
Solution #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivan-Shvorak
suggested changes
Aug 5, 2024
|
|
||
| describe('Web Tables page', () => { | ||
| it('', () => { | ||
| beforeEach(() => { |
There was a problem hiding this comment.
add empty lines between beforeEach and all tests
| beforeEach(() => { | ||
| cy.visit('https://demoqa.com/webtables'); | ||
| }); | ||
| it('should check Pagination', () => { |
There was a problem hiding this comment.
Please consider that describe + test name should create summary together - in this case we have
Web Tables page + should check Pagination // Web Tables shouldn't check pagination.
Better to write
Web Tables page + should allow user to change page
Check and fix everywhere
| cy.visit('https://demoqa.com/webtables'); | ||
| }); | ||
| it('should check Pagination', () => { | ||
| cy.get('.rt-tbody .rt-tr-group').should('have.length', 10); |
There was a problem hiding this comment.
Try to use more descriptive selectors everywhere
| cy.get('.rt-tbody .rt-tr-group').should('have.length', 10); | ||
| cy.get('.-next').should('be.visible').and('not.be.disabled'); | ||
| cy.get('img[src="/images/Toolsqa.jpg"]').should('exist'); | ||
| cy.url().should('eq', 'https://demoqa.com/webtables'); |
There was a problem hiding this comment.
Not sure what this assert is doing here
| cy.get(`.rt-noData`).should('contain', 'No rows found'); | ||
| }); | ||
| it('should Find a worker in the search field and edit it.', () => { | ||
| cy.get('input#searchBox').type('Cierra'); |
| }); | ||
| it('should Find a worker in the search field and edit it.', () => { | ||
| cy.get('input#searchBox').type('Cierra'); | ||
| cy.get('input#searchBox').clear(); |
There was a problem hiding this comment.
Where do we have asserts to check search results?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.