Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #616

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ihorkorshylivskyi
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on structuring the Cypress test file for the Sign In page! 🎉 The code meets the task requirements and effectively automates the login flow. There's a minor issue with the error message assertion for invalid credentials due to an extra space. Make sure to align the expected text with the actual message displayed on the page. Keep up the good work and happy coding! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +24 to +25

cy.get('#flash').should('contain.text', ' Your username is invalid!');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an extra space at the beginning of the expected error message text. Ensure that the expected text matches exactly what is displayed on the page, or remove the extra space if it is not present in the actual message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants