solution #183
solution #183
Conversation
There was a problem hiding this comment.
It looks like there are several critical issues that need to be addressed to ensure the functionality of the code. Each method is missing essential parameters, and the navigation path is incomplete. Once these are fixed, your code will be in great shape! Keep up the good work and don't hesitate to reach out if you need any help. 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
cypress/e2e/settings.cy.js
Outdated
| }); | ||
|
|
||
| beforeEach(() => { | ||
|
|
||
| cy.task('db:clear'); | ||
| cy.visit(''); |
There was a problem hiding this comment.
The cy.visit(''); line should include the URL or path to the page you want to visit. Currently, it is empty, which means Cypress will not navigate to any page.
|
|
||
| settingsPage.editUsername(user.username); | ||
| settingsPage.submitEdit(); | ||
| settingsPage.verifyProfilePage(user.username); |
There was a problem hiding this comment.
The verifyProfilePage method is called with user.username, but the default parameter in verifyProfilePage is 'riot'. Ensure that the verifyProfilePage method in settings.pageObject.js is correctly using the passed username parameter.
| } | ||
|
|
||
| editUsername() { | ||
| this.usernameField.clear().type(username); |
There was a problem hiding this comment.
The editUsername method is missing the username parameter. You should pass username as an argument to this method to ensure it works correctly.
| } | ||
|
|
||
| editBio() { | ||
| this.bioField.clear().type(bio); |
There was a problem hiding this comment.
The editBio method is missing the bio parameter. You should pass bio as an argument to this method to ensure it works correctly.
| } | ||
|
|
||
| editEmail() { | ||
| this.emailField.clear().type(email); |
There was a problem hiding this comment.
The editEmail method is missing the email parameter. You should pass email as an argument to this method to ensure it works correctly.
| } | ||
|
|
||
| editPassword() { | ||
| this.passwordField.clear().type(password); |
There was a problem hiding this comment.
The editPassword method is missing the password parameter. You should pass password as an argument to this method to ensure it works correctly.
There was a problem hiding this comment.
Great work on implementing the functionality! 🎉 There are a few areas for improvement: ensure methods like verifyLogout and verifyProfilePage can handle dynamic usernames, and verify updates for password, email, and bio changes. Also, make sure the cy.login() and cy.register() methods use the same user data for consistency. Addressing these will enhance your code's robustness. Keep learning and improving! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
|
|
||
| cy.task('db:clear'); | ||
| cy.visit('/'); | ||
| cy.register(); |
There was a problem hiding this comment.
The cy.register() method is called here, but it is not clear if it uses the user object generated in the before hook. Ensure that the registration process uses the same user data to maintain consistency across tests.
| cy.task('db:clear'); | ||
| cy.visit('/'); | ||
| cy.register(); | ||
| cy.login(); |
There was a problem hiding this comment.
The cy.login() method is called here, but it is not clear if it uses the user object generated in the before hook. Ensure that the login process uses the same user data to maintain consistency across tests.
|
|
||
| settingsPage.editUsername(user.username); | ||
| settingsPage.submitEdit(); | ||
| settingsPage.verifyProfilePage(user.username); |
There was a problem hiding this comment.
The verifyProfilePage method is used here to verify the username update. Ensure that this method correctly checks the updated username on the profile page.
| }); | ||
|
|
||
| it('should provide an ability to update bio', () => { | ||
|
|
||
| settingsPage.editBio(user.bio); | ||
| settingsPage.submitEdit(); |
There was a problem hiding this comment.
After updating the bio, consider adding a verification step similar to the username update to ensure the bio has been updated successfully.
| }); | ||
|
|
||
| it('should provide an ability to update an email', () => { | ||
|
|
||
| settingsPage.editEmail(user.email); | ||
| settingsPage.submitEdit(); |
There was a problem hiding this comment.
After updating the email, consider adding a verification step to ensure the email has been updated successfully.
| }); | ||
|
|
||
| it('should provide an ability to update password', () => { | ||
|
|
||
| settingsPage.editPassword(user.password); | ||
| settingsPage.submitEdit(); |
There was a problem hiding this comment.
After updating the password, consider adding a verification step to ensure the password has been updated successfully.
| }); | ||
|
|
||
| it('should provide an ability to log out', () => { | ||
|
|
||
| settingsPage.logoutUser(); | ||
| settingsPage.verifyLogout(); |
There was a problem hiding this comment.
The verifyLogout method is used here to verify the logout functionality. Ensure that this method correctly checks that the user is logged out.
| this.logoutBtn.click(); | ||
| } | ||
|
|
||
| verifyProfilePage(username='riot') { |
There was a problem hiding this comment.
The verifyProfilePage method uses a default username 'riot'. Ensure that this method can accept dynamic usernames to verify the profile page for different users.
| return cy.url().should('contain', `/profile/${username}`); | ||
| } | ||
|
|
||
| verifyLogout(username='riot') { |
There was a problem hiding this comment.
The verifyLogout method uses a default username 'riot'. Ensure that this method can accept dynamic usernames to verify the logout functionality for different users.
No description provided.