Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cypress e2e test #617

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

cypress e2e test #617

wants to merge 1 commit into from

Conversation

vlad-fil
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on setting up the Cypress tests! 🎉 Your code meets the task requirements and is well-structured. Just a couple of tips: consider using more robust selectors to avoid potential issues if the page structure changes, and ensure that you're using test credentials instead of real user data. Keep up the good work! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +10 to +11
cy.get(':nth-child(1) > .form-control').type('[email protected]');
cy.get(':nth-child(2) > .form-control').type('12345678');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the email and password used for testing are valid and correspond to a test account in your application. Using real user credentials is not recommended for automated tests.

Comment on lines +13 to +14
cy.get(':nth-child(4) > .nav-link').click();
cy.get('h4').should('contain.text', 'vladfil');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The selector :nth-child(4) > .nav-link assumes a specific structure of the navigation bar. If the structure changes, this selector might break. Consider using a more robust selector if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants