-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing #300
base: main
Are you sure you want to change the base?
Testing #300
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on the pull request! 🎉 While there are a few typos, they don't significantly impact the functionality. Just make sure to correct them in future updates. Keep up the good work!
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
describe('', () => { | ||
before(() => { | ||
/// <reference types='cypress' /> | ||
import { generateUser, generateeArticle } from '../support/generate'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a typo in the import statement. It should be generateArticle
instead of generateeArticle
.
|
||
describe('Article flow', () => { | ||
const user = generateUser(); | ||
const article = generateeArticle(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The function generateeArticle
is misspelled. It should be generateArticle
to match the import statement.
}; | ||
}; | ||
|
||
export const generateeArticle = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a typo in the function name 'generateeArticle'. It should be 'generateArticle'.
title: faker.word.words(1), | ||
description: faker.word.words(5), | ||
body: faker.word.words(10), | ||
tag: faker.word.words(1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The property 'tag' should likely be an array of words (tags) rather than a single word. Consider using 'faker.word.words(1).split()' or a similar method to generate an array.
No description provided.