Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #117

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Solution #117

wants to merge 1 commit into from

Conversation

OksanaW8
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on covering a wide range of scenarios in your test cases for the validateEmail function! 🎉 Your tests are well-structured and align with the task requirements, ensuring that both valid and invalid email formats are thoroughly checked. Although there are some minor issues mentioned, such as ensuring the function correctly handles special characters and dots at the beginning or end of an email, these do not significantly impact the overall functionality. Keep up the good work, and consider refining these areas for even more robust testing in the future! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +26 to +28
it(`should return 'false' for the invalid email that
contains not allowed chars
! $ % & ' * + / = ? ^ { | } ~ :

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test description mentions several special characters that are not allowed in an email address. Ensure that the validateEmail function correctly handles these characters.

Comment on lines +43 to +45
it(`should return 'false' if in dots are at the beginning
or at the end of the string`, () => {
expect(validateEmail('[email protected].')).toBeFalsy();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test case checks for dots at the beginning or end of the email. Ensure that the validateEmail function correctly identifies these as invalid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants