add solution #126
add solution #126
Conversation
There was a problem hiding this comment.
Great job on implementing the checkPassword function! 🎉 Your solution meets the task requirements and constraints effectively. While the test descriptions had some inconsistencies, your code correctly handles the password validation rules. Just make sure to update the test descriptions to accurately reflect the requirements, ensuring clarity for future reviews. Keep up the excellent work! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
src/checkPassword.test.js
Outdated
| it(`should accept\`Aa-Яя\` letters`, () => { | ||
| expect(checkPassword('ЯP@ssword1я')).toBeFalsy(); |
There was a problem hiding this comment.
The test case description should accept 'Aa-Яя' letters is misleading. According to the task requirements, the function should only accept Latin alphabet letters Aa-Zz. Therefore, the expectation for checkPassword('ЯP@ssword1я') should be false, but the description suggests it should be true. Please revise the test description to align with the requirements.
src/checkPassword.test.js
Outdated
| it(`should not contain at least 1 digit`, () => { | ||
| expect(checkPassword('P@ssssdf')).toBeFalsy(); |
There was a problem hiding this comment.
The test description should not contain at least 1 digit is incorrect. The requirement is that the password should contain at least one digit. Therefore, the description should be revised to reflect that the password must include at least one digit.
src/checkPassword.test.js
Outdated
| it(`should not contain at least 1 special character`, () => { | ||
| expect(checkPassword('Pssssdf1')).toBeFalsy(); |
There was a problem hiding this comment.
The test description should not contain at least 1 special character is incorrect. The requirement is that the password should contain at least one special character. Please update the description to accurately reflect this requirement.
src/checkPassword.test.js
Outdated
| it(`should not contain at least 1 uppercase letter`, () => { | ||
| expect(checkPassword('p@ssssdf1')).toBeFalsy(); |
There was a problem hiding this comment.
The test description should not contain at least 1 uppercase letter is incorrect. The requirement is that the password should contain at least one uppercase letter. Please revise the description to align with the task requirements.
No description provided.