Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the task is complete #123

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

the task is complete #123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
module.exports = {
extends: '@mate-academy/eslint-config',
extends: "@mate-academy/eslint-config",
env: {
jest: true
jest: true,
},
rules: {
'no-proto': 0
"no-proto": 0,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The no-proto rule is set to 0, which disables the rule that prevents the use of __proto__. This can lead to potential security and performance issues. Consider enabling this rule unless you have a specific reason to allow __proto__.

quotes: "off",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The quotes rule is set to "off", which means that ESLint will not enforce any specific quote style. This might lead to inconsistent quote usage in your code. Consider setting it to "single" or "double" to enforce consistency, unless the extended configuration already handles this.

},
plugins: ['jest']
plugins: ["jest"],
};
23 changes: 23 additions & 0 deletions .github/workflows/test.yml-template
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
name: Test

on:
pull_request:
branches: [ master ]

jobs:
build:

runs-on: ubuntu-latest

strategy:
matrix:
node-version: [20.x]

steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- run: npm install
- run: npm test
Loading