Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #122

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Develop #122

wants to merge 2 commits into from

Conversation

Karanelus
Copy link

Tests added

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the checkPassword function and creating comprehensive tests! 🎉 The function meets the task requirements and constraints effectively. Although there's a minor syntax error in the regular expression declaration, it doesn't significantly impact the overall functionality. Keep up the great work, and consider fixing that small issue to make your code even better! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

@@ -7,11 +7,15 @@
*/
function checkPassword(password) {
// eslint-disable-next-line
const validPasswordRegex = /^(?=.*\d)(?=.*[a-z])(?=.*[A-Z])(?=.*[^a-zA-Z0-9])(?!.*\s).{8,16}$/;
const validPasswordRegex =

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a syntax error here. The regular expression should be assigned to the validPasswordRegex variable without the /++10++/ marker. It should be on a separate line or combined with the next line correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants