Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests #119

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add tests #119

wants to merge 1 commit into from

Conversation

KatOlista
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the checkPassword function! 🎉 Your code meets all the task requirements and constraints, and the tests are well-structured to ensure correctness. There are just a couple of minor typos in the test descriptions that you might want to correct for clarity: "longer then 16" should be "longer than 16" and "short then 8" should be "shorter than 8". Keep up the great work! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

});

// write more tests here
it(`should return 'false' for the password short then 8`, () => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in the test description: 'short then 8' should be 'shorter than 8'.

expect(result).toBeFalsy();
});

it(`should return 'false' for the password longer then 16`, () => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in the test description: 'longer then 16' should be 'longer than 16'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants