Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solution #1193

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

solution #1193

wants to merge 3 commits into from
+382 −55

Conversation

CNegruzzi
Copy link

vadiimvooo
vadiimvooo suggested changes Feb 12, 2025
View reviewed changes
Copy link

@vadiimvooo vadiimvooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, but there is an issue which needs to be fixed:

  1. When cells wasn't merged by move, you should not add new one on table.
    image
    But instead you do
    image

@CNegruzzi CNegruzzi requested a review from vadiimvooo February 13, 2025 15:09
etojeDenys
etojeDenys suggested changes Feb 13, 2025
View reviewed changes
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after the loss, if I click the restart button, it always shows the start button
image

  1. do not add the cell if the board didn't change
Screen.Recording.2025-02-13.at.21.09.42.mov

@CNegruzzi CNegruzzi requested a review from etojeDenys February 14, 2025 21:38
etojeDenys
etojeDenys suggested changes Feb 15, 2025
View reviewed changes
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's still not fixed

Screen.Recording.2025-02-15.at.10.05.43.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etojeDenys etojeDenys etojeDenys requested changes

@vadiimvooo vadiimvooo Awaiting requested review from vadiimvooo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CNegruzzi @etojeDenys @vadiimvooo