Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop #1185

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Develop #1185

wants to merge 5 commits into from

Conversation

Artemida1609
Copy link

No description provided.

anastasiiavorobiova
anastasiiavorobiova suggested changes Feb 9, 2025
View reviewed changes
Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

  • Consider hiding the start message after the start
  • Screenshot 2025-02-09 at 14 15 19
  • Consider adding the new number only if the game field is changed

anastasiiavorobiova
anastasiiavorobiova suggested changes Feb 9, 2025
View reviewed changes
Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

  • Consider adding the new number only if the game field is changed

anastasiiavorobiova
anastasiiavorobiova suggested changes Feb 9, 2025
View reviewed changes
Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider fixing previous comment and deploying your solution
Feel free to ask for help in the chat

@Artemida1609
Copy link
Author

Hello! But I have fixed those mistakes, or no ?

@Artemida1609
Copy link
Author

Excuse me, are you here ?

@Artemida1609
Copy link
Author

@anastasiiavorobiova

etojeDenys
etojeDenys suggested changes Feb 9, 2025
View reviewed changes
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not add a cell if the board didn't change

Screen.Recording.2025-02-09.at.19.08.02.mov

@Artemida1609
Copy link
Author

Now it works as you asked.

vadiimvooo
vadiimvooo approved these changes Feb 9, 2025
View reviewed changes
Copy link

@vadiimvooo vadiimvooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadiimvooo vadiimvooo vadiimvooo approved these changes

@anastasiiavorobiova anastasiiavorobiova Awaiting requested review from anastasiiavorobiova

@etojeDenys etojeDenys Awaiting requested review from etojeDenys

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Artemida1609 @etojeDenys @vadiimvooo @anastasiiavorobiova