Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #1174

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

add task solution #1174

wants to merge 7 commits into from

Conversation

Katy4S
Copy link

@Katy4S Katy4S commented Feb 5, 2025

- [DEMO LINK](https://Katy4S.github.io/js_2048_game/)

Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to deploy your solution
Feel free to ask for help in the chat

@Katy4S
Copy link
Author

Katy4S commented Feb 5, 2025

2048_1 2048_2

Please check the task as it all works, all is deployed, but due to the time it takes to pass the tests they fail.

Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your demo link doesn't work, try to ask for some help about it in the chat
image
and then re-request the review

@Katy4S Katy4S requested a review from etojeDenys February 5, 2025 20:11
@Katy4S
Copy link
Author

Katy4S commented Feb 5, 2025

I have asked for help in the QA today, and all worked. I have done all and the test, all, why this is going?

@Katy4S
Copy link
Author

Katy4S commented Feb 5, 2025

it works in my computer
Monosnap 2048 2025-02-05 23-38-38

Copy link

@maxim2310 maxim2310 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have same situation with demo link, plz fix it, if you have questions plz ask in FE_chat
image

@Katy4S Katy4S requested a review from maxim2310 February 7, 2025 18:40
@Katy4S
Copy link
Author

Katy4S commented Feb 7, 2025

please recheck, all should work now. thank you!

Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you need two restart buttons, remove one
image

  1. if the board didn't change do not add the new cell
Screen.Recording.2025-02-07.at.21.03.49.mov

@Katy4S Katy4S requested a review from etojeDenys February 9, 2025 12:36
@Katy4S
Copy link
Author

Katy4S commented Feb 9, 2025

Hi, I have done the asked improvements

2048_1 2048_2

please check how it works and if it satisfies the instructions provided.
thank you!

Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

  • Consider adding the new number only if the game field is changed

@Katy4S
Copy link
Author

Katy4S commented Feb 9, 2025

hi, please check the task again.
I tried to do that it worked, I suppose I did.
If not I will try to rede, please give me advice then where to check and do corrections in the code.
Thank you!

Copy link

@vadiimvooo vadiimvooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done

Copy link

@vadiimvooo vadiimvooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants