first commit #1172
Open
first commit #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etojeDenys
suggested changes
Feb 4, 2025
There was a problem hiding this comment.
https://SerhiiUnhurian.github.io/js_2048_game/
fix the demo link and then re-request the review
VitaliyBondarenko1982
suggested changes
Feb 5, 2025
src/modules/Game.class.js
Outdated
|
|
||
| /** | ||
| * Resets the game. | ||
| */ | ||
| restart() {} | ||
| restart() { | ||
| this.initGame(); |
There was a problem hiding this comment.
after restart game board should be without any tiles.
maxim2310
suggested changes
Feb 6, 2025
etojeDenys
suggested changes
Feb 6, 2025
|
I'm making new deployments but for some reason they don't appear, |
volodymyr-soltys97
suggested changes
Feb 6, 2025
|
check pls |
volodymyr-soltys97
suggested changes
Feb 6, 2025
src/modules/Game.class.js
Outdated
Comment on lines
168
to
181
| // updateTable() { | ||
| // const cells = document.querySelectorAll('.field-cell'); | ||
| // let index = 0; | ||
|
|
||
| // this.board.forEach((row) => { | ||
| // row.forEach((cellValue) => { | ||
| // const cell = cells[index++]; | ||
|
|
||
| // cell.textContent = cellValue !== 0 ? cellValue : ''; | ||
| // eslint-disable-next-line max-len | ||
| // cell.className = `field-cell ${cellValue ? 'field-cell--' + cellValue : ''}`; | ||
| // }); | ||
| // }); | ||
| // } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.