add task solution #1171
add task solution #1171
Conversation
JosielLinhar
commented
Feb 4, 2025
JosielLinhar
commented
- DEMO LINK
There was a problem hiding this comment.
Great job on implementing the 2048 game! 🎉 Your code meets the task requirements and effectively handles the game logic and user interactions. While there are a few minor improvements suggested, such as ensuring win/lose messages are hidden on restart and returning the updated state in some methods for consistency, these do not impact the core functionality. Keep up the good work and consider these enhancements for an even smoother user experience! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| moveRight() { | ||
| if (this.getStatus() === 'playing') { | ||
| this.reverseState(); | ||
| this.moveLeft(); | ||
| this.reverseState(); | ||
| } | ||
| } |
There was a problem hiding this comment.
The moveRight method does not return the updated state after performing the move. Consider returning this.state at the end of the method to maintain consistency with moveLeft.
| moveUp() { | ||
| if (this.getStatus() === 'playing') { | ||
| this.flipState(); | ||
| this.moveLeft(); | ||
| this.flipState(); | ||
| } | ||
| } |
There was a problem hiding this comment.
The moveUp method does not return the updated state after performing the move. Consider returning this.state at the end of the method to maintain consistency with moveLeft.
| moveDown() { | ||
| if (this.getStatus() === 'playing') { | ||
| this.flipState(); | ||
| this.moveRight(); | ||
| this.flipState(); | ||
| } | ||
| } |
There was a problem hiding this comment.
The moveDown method does not return the updated state after performing the move. Consider returning this.state at the end of the method to maintain consistency with moveLeft.
| game.restart(); | ||
| updateTable(game.getState()); | ||
| updateScore(game.getScore()); | ||
| winOrLose(); | ||
|
|
||
| button.classList.replace('restart', 'start'); | ||
| button.innerHTML = 'Start'; | ||
|
|
||
| messageStart.classList.remove('hidden'); |
There was a problem hiding this comment.
When restarting the game, ensure that the win and lose messages are hidden. Currently, only the start message is shown, but if the game was previously won or lost, those messages might still be visible. Consider adding messageWin.classList.add('hidden'); and messageLose.classList.add('hidden'); to ensure they are hidden when the game restarts.
