Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre hooks #87

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions mate-scripts/configs/git-hooks/react/pre-commit
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
#!/bin/bash

function join_by { local IFS="$1"; shift; echo "$*"; }

PASS=true

# ESLint
STAGED_JS_FILES=$(git diff --cached --name-only --diff-filter=ACM ./src | grep ".\(j\|t\)sx\{0,1\}$")

if [[ "$STAGED_JS_FILES" != "" ]]; then
echo "Linting javascript files"

npx mate-scripts lint --javascript $(join_by " " ${STAGED_JS_FILES})

if [[ "$?" == 0 ]]; then
printf "\033[32mESLint Passed\033[0m\n\n"
else
printf "\033[031mESLint Failed\033[0m\n\n"
PASS=false
fi
fi

# StyleLint
STAGED_CSS_FILES=$(git diff --cached --name-only --diff-filter=ACM ./src | grep ".s\?css$")

if [[ "$STAGED_CSS_FILES" != "" ]]; then
echo "Linting CSS files"

npx mate-scripts lint --styles $(join_by " " ${STAGED_CSS_FILES})

if [[ "$?" == 0 ]]; then
printf "\033[32mStyleLint Passed\033[0m\n\n"
else
printf "\033[031mStyleLint Failed\033[0m\n\n"
PASS=false
fi
fi

if ! ${PASS}; then
printf "Pre-commits check failed. Fix problems above before commit.\n\n"
exit 1
fi
42 changes: 42 additions & 0 deletions mate-scripts/configs/git-hooks/reactTypescript/pre-commit
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
#!/bin/bash

function join_by { local IFS="$1"; shift; echo "$*"; }

PASS=true

# ESLint
STAGED_JS_FILES=$(git diff --cached --name-only --diff-filter=ACM ./src | grep ".\(j\|t\)sx\{0,1\}$")

if [[ "$STAGED_JS_FILES" != "" ]]; then
echo "Linting javascript files"

npx mate-scripts lint --javascript $(join_by " " ${STAGED_JS_FILES})

if [[ "$?" == 0 ]]; then
printf "\033[32mESLint Passed\033[0m\n\n"
else
printf "\033[031mESLint Failed\033[0m\n\n"
PASS=false
fi
fi

# StyleLint
STAGED_CSS_FILES=$(git diff --cached --name-only --diff-filter=ACM ./src | grep ".s\?css$")

if [[ "$STAGED_CSS_FILES" != "" ]]; then
echo "Linting CSS files"

npx mate-scripts lint --styles $(join_by " " ${STAGED_CSS_FILES})

if [[ "$?" == 0 ]]; then
printf "\033[32mStyleLint Passed\033[0m\n\n"
else
printf "\033[031mStyleLint Failed\033[0m\n\n"
PASS=false
fi
fi

if ! ${PASS}; then
printf "Pre-commits check failed. Fix problems above before commit.\n\n"
exit 1
fi
2 changes: 1 addition & 1 deletion mate-scripts/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@mate-academy/scripts",
"version": "0.9.6",
"version": "0.9.7",
"description": "Scripts to init, run, test, deploy Mate academy homework projects",
"main": "bin/mateScripts.js",
"scripts": {
Expand Down
10 changes: 10 additions & 0 deletions mate-scripts/src/commands/Init.command.ts
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,16 @@ export class InitCommand extends Command {
this.initGitHooks(ProjectTypes.Javascript);
};

protected react = () => {
this.copyProjectTypeSpecificConfigs(ProjectTypes.React);
this.initGitHooks(ProjectTypes.React);
};

protected reactTypescript = () => {
this.copyProjectTypeSpecificConfigs(ProjectTypes.ReactTypescript);
this.initGitHooks(ProjectTypes.ReactTypescript);
};

private copyCommonConfigs() {
const commonConfigsDir = path.join(InitCommand.configsDir, 'common');

Expand Down