Trim leading/trailing spaces after topformflat #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emaxx-google
commented
Jan 22, 2025
| ): | ||
| backup.close() | ||
| with open(test_case) as in_file: | ||
| try: | ||
| cmd = [self.external_programs['topformflat'], self.arg] | ||
| proc = subprocess.run(cmd, stdin=in_file, capture_output=True, text=True) | ||
| with subprocess.Popen(cmd, stdin=in_file, stdout=subprocess.PIPE, text=True) as proc: |
There was a problem hiding this comment.
I took the liberty to change this to read stdout per line, instead of accumulating everything in the memory. It's not a big speedup (transform and __count_instances load the whole file anyway), but the optimization felt easily doable...
emaxx-google
force-pushed
the
strip-lines
branch
from
8c7df7f to
28b9365
Compare
This reduces the overhead slightly and prevents the files from growing noticeably when the lines passes start. Note that this new logic has a safeguard that falls back to the previous behavior (which takes the topformflat's output as-is) in case the interestingness script starts failing.
emaxx-google
force-pushed
the
strip-lines
branch
from
28b9365 to
f973363
Compare
emaxx-google
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the overhead slightly and prevents the files from
growing noticeably when the lines passes start. This fixes #163.
Note that this new logic has a safeguard that falls back to the
previous behavior (which takes the topformflat's output as-is) in
case the interestingness script starts failing.