Fix hang when buggy (unaltered) OK comes after STOP #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emaxx-google
changed the title
emaxx-google
force-pushed
the
fix-misbehave-after-stop-hang
branch
2 times, most recently
from
0b47c5c to
7f2e6cd
Compare
Make sure that we don't proceed with an unmodified file - for this, consistently validate the pass' results on both codepaths (in process_done_futures() and wait_for_first_success()). Besides fixing the hang that was possible when a pass misbehaved, there are a couple of other side effects: * more cases of ERRORs in a pass will be reported - previously only the ones on the first codepath were handled; * max_improvement is enforced stricter now - previously the second codepath allowed a larger reduction to sneak in. This fixes marxin#156.
emaxx-google
force-pushed
the
fix-misbehave-after-stop-hang
branch
from
7f2e6cd to
b23e6b2
Compare
emaxx-google
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that we don't proceed when a buggy pass returns an
unmodified file - for this, consistently validate the pass' results on
both codepaths (in process_done_futures() and wait_for_first_success()).
Besides fixing the hang that was possible when a pass misbehaved,
there are a couple of other side effects:
the ones on the first codepath were handled;
codepath allowed a larger reduction to sneak in.
This fixes #156.