Screen buffer #58
Open
Screen buffer #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: a99e46f ("Simplify I/O handling") Signed-off-by: Alexey Gladkov <[email protected]>
When a client attaches to an existing session, the session command output is not available to him. The problem is not noticeable when the program (top, man, etc.) in the session is able to redraw its output. But this does not work with non-interactive utilities. The output of commands in bash will not be available to the client connecting to the session. To solve this, we add a buffer that contains the last few lines of the session output. When a new client attaches, the contents of this buffer are sent to him. Signed-off-by: Alexey Gladkov <[email protected]>
|
this is brilliant! any chances of merging @martanne? |
|
@megalithic I haven't seen activity here in years. I maintain my fork. |
thanks @legionus! i've switched to building from your repo from source. cheers! |
@megalithic If you have any other suggestions, I'm ready to add to my fork. I hope in the future I will have a chance to discuss them with upstream. |
|
hi @martanne , many thanks for you work! cheers Max |
|
@martanne What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a client attaches to an existing session, the session command output is not available to him. The problem is not noticeable when the program (top, man, etc.) in the session is able to redraw its output.
But this does not work with non-interactive utilities. The output of commands in bash will not be available to the client connecting to the session.
To solve this, we add a buffer that contains the last few lines of the session output. When a new client attaches, the contents of this buffer are sent to him.
This PR could address #57, #32 and maybe more.