fix bug where attaching to dead session won't give underlying exit code #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If dvtm dies, and you run `:|abduco -a session`, abduco will often exit without giving you the exit code, and without removing the socket from ~/.abduco. We resolve this by first sending the client either an EXIT or an empty CONTENT packet. Only after the client recieves it, we set the socket to non-blocking. Fixes: martanne#44
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If dvtm dies, and you run
:|abduco -a session, abduco will often exitwithout giving you the exit code, and without removing the socket from
~/.abduco.
We resolve this by first sending the client either an EXIT or an empty
CONTENT packet.
Only after the client recieves it, we set the socket to non-blocking.
Fixes: #44