This repository has been archived by the owner on Jan 17, 2025. It is now read-only.
feat: display unsubmitted assignments on the manaba home page #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| .then((DOM) => asgPageTable(DOM)) | ||
| .then((table) => table && getAsgsFromTable(table)) | ||
|
|
||
| const renderUnsubmittedAsgsOnHome = ( |
There was a problem hiding this comment.
Function renderUnsubmittedAsgsOnHome has 46 lines of code (exceeds 25 allowed). Consider refactoring.
|
@mkobayashime I'd rather get this PR ready for review after #505 and #558 are resolved. |
yudukikun5120
changed the title
|
Code Climate has analyzed commit 1c7cb4d and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.