Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEB-2804]fix: subscribed issues count #6525

Draft
wants to merge 2 commits into
base: preview
Choose a base branch
from

Conversation

sangeethailango
Copy link
Collaborator

@sangeethailango sangeethailango commented Jan 31, 2025

Description

This PR will fix the wrong count of subscribed issues.

Summary by CodeRabbit

  • Bug Fixes
    • Enhanced issue counting mechanism to ensure only active (non-deleted) projects and issues are included in workspace user profile statistics.

Copy link
Contributor

coderabbitai bot commented Jan 31, 2025

Walkthrough

The pull request introduces additional filtering conditions in the WorkspaceUserProfileStatsEndpoint and WorkspaceUserProfileIssuesEndpoint classes. It adds checks to ensure that both the project and issue are not marked as deleted by including project__deleted_at__isnull=True and issue__deleted_at__isnull=True in the respective queries. This change modifies the logic for counting created, assigned, and subscribed issues, ensuring that only active (non-deleted) projects and issues are included in these counts.

Changes

File Change Summary
apiserver/plane/app/views/workspace/user.py Added project__deleted_at__isnull=True and issue__deleted_at__isnull=True filters to WorkspaceUserProfileStatsEndpoint and WorkspaceUserProfileIssuesEndpoint for counting issues.

Possibly related PRs

Suggested reviewers

  • pablohashescobar
  • pushya22

Poem

🐰 In the realm of code, a rabbit's delight,
Deleted issues now fade from sight.
With a filter so neat, so clean and bright,
Counting subscriptions becomes just right.
A hop of precision, a leap of might! 🔍


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 89539be and e2b1cf3.

📒 Files selected for processing (1)
  • apiserver/plane/app/views/workspace/user.py (3 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • apiserver/plane/app/views/workspace/user.py
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Analyze (javascript)
  • GitHub Check: Analyze (python)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sangeethailango sangeethailango changed the title fix: subscribed issues count WEB-2804]fix: subscribed issues count Jan 31, 2025
@sangeethailango sangeethailango changed the title WEB-2804]fix: subscribed issues count [WEB-2804]fix: subscribed issues count Jan 31, 2025
@sangeethailango sangeethailango force-pushed the fix-subscribed-issues-count branch from c13075a to 89539be Compare January 31, 2025 10:07
@sangeethailango sangeethailango marked this pull request as draft January 31, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant