Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issues 38540 #39320

Open
wants to merge 8 commits into
base: 2.4-develop
Choose a base branch
from
Open

Conversation

shmVan
Copy link
Contributor

@shmVan shmVan commented Nov 3, 2024

  • fix Module Magento\Quote. The object $this->_customer always exists. Added a check for the existence of $this->getCustomerId() / If it is true  $this->setCustomerIsGuest(false);

Description (*)

This issue is caused when checking out from a guest cart programmatically, when you assign a customer to the cart before submitting it to place the order, the quote remains as guest even though a customer has been assigned.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes When customer is set for quote order is still a guest order #38540

Manual testing scenarios (*)

  1. Install custom module I38540V
  2. Run command bin/magento order:place
  3. After saving the quote, the customer_is_guest value must be false
    2024-07-12_11-52

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Copy link

m2-assistant bot commented Nov 3, 2024

Hi @shmVan. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@m2-community-project m2-community-project bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Nov 3, 2024
@m2-github-services m2-github-services added Partner: Perspective Team partners-contribution Pull Request is created by Magento Partner labels Nov 3, 2024
@shmVan
Copy link
Contributor Author

shmVan commented Nov 8, 2024

@magento run all tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Partner: Perspective Team partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When customer is set for quote order is still a guest order
4 participants