Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for mailgun variables #203

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

belidzs
Copy link
Contributor

@belidzs belidzs commented May 25, 2020

Fixes #201

@belidzs belidzs changed the title Add support for mailgun variables #201 Add support for mailgun variables May 25, 2020
@lukencode
Copy link
Owner

Hi @belidzs and @klevisndoka I am going to find time in the next week to review all these PRs and get a new release going. Thanks heaps for your work (and sorry for the delay on my end)

@lukencode
Copy link
Owner

This is very similar to #204 . I suggested maybe a renderer is the best option (though we might have to change some core core)

@belidzs
Copy link
Contributor Author

belidzs commented Aug 6, 2020

@lukencode not really, these variables primarily serve as metadata, so using them in rendering is only a secondary thing.

For instance if a developer sends a notification about a new invoice generated in their application they can pass the invoice ID so when the message is delivered (and mailgun calls your configured web service as a result) it also includes these variables as easily processable variables.

@stefankip
Copy link

Too bad this has bled to death

@belidzs belidzs force-pushed the mailgun-variables branch from a29f45a to 64cf341 Compare April 24, 2022 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mailgun Recipient-Variables
4 participants